Subject: Re: CVS commit: src/usr.bin/kdump
To: David Laight <dsl@NetBSD.org>
From: John Hawkinson <jhawk@MIT.EDU>
Date: 11/18/2003 13:25:22
David Laight <dsl@NetBSD.org> wrote on Tue, 18 Nov 2003
at 13:21:54 +0000 in <20031118132154.0EB092DA1D@cvs.netbsd.org>:
> Log Message:
> - Stop core dump is an ioctl trace has fewer than expeceted arguments.
I editted this log message to "Stop core dump if an ioctl trace has
fewer than expected arguments," since I think that's what you meant
and it took me a while to parse your original text.
> - Check names of system calls (for special treatment) because emulations
> might use different numbers.
> - Report an error if arguments to -p or -m non-numeric.
> - Just take last of -x and -Xvalue, stop -X0x80000000 being valid (core dumps).
> - Keep 'last used' emulation_ctx at top of list, create on lookup (usually
> EMUL anyway), delete when exit called (doesn't return).
> - Slightly improve hack to get correct system call name in execve return
> when emulation has changed.
> - Rename global variables 'current'/'previous' to 'cur_emul'/'prev_emul'.
> (TODO: save system call type (and maybe an argument) per pid so GIO trace
> format can depend on the actual system call.)
> Fixes part of PR sparc64/23473 - but system call arguments will still not be
> displayed correctly.
> To generate a diff of this commit:
> cvs rdiff -r1.66 -r1.67 src/usr.bin/kdump/kdump.c
> cvs rdiff -r1.17 -r1.18 src/usr.bin/kdump/setemul.c
> cvs rdiff -r1.10 -r1.11 src/usr.bin/kdump/setemul.h