Subject: Re: CVS commit: src/sys/sys
To: Izumi Tsutsui <email@example.com>
From: Luke Mewburn <lukem@NetBSD.org>
Date: 11/14/2003 23:25:18
On Fri, Nov 14, 2003 at 09:19:33PM +0900, Izumi Tsutsui wrote:
| In article <20031114113254.O4919@snowdrop.l8s.co.uk>
| firstname.lastname@example.org wrote:
| > sys/disklabel could be in src/tools/compat/sys - but you still need to
| > stop in going after machine/* since you don't know 'machine'.
| You could create symlinks which points to files in proper machine dirs.
IMHO, that is not an acceptable solution.
| > I used MAXPARTITIONS because that is the value that sys/disklabel.h
| > needs from machine/disklabel.h
| I think what you want to do exactly is
| "including declarations of struct disklabel and struct pattitions
| without including <machine/disklabel.h>", right?
| Then using MAXPARTITIONS or _MACHINE_DISKLABEL_H_ is
| not correct even if it works for now.
| It's still better to add declarations into sys/bootblock.h
| to define info about target machines.
The latter is the correct solution; sys/bootblock.h should have a
definition for the disklabel that the host's native boot mechanism
uses, as per next68k_disklabel in that file. I want to review any
such changes before they are committed.