Subject: Re: CVS commit: src/sys/sys
To: matthew green <>
From: David Laight <>
List: source-changes
Date: 11/14/2003 09:06:34
On Fri, Nov 14, 2003 at 07:18:14PM +1100, matthew green wrote:
>    Module Name:	src
>    Committed By:	dsl
>    Date:		Fri Nov 14 08:03:16 UTC 2003
>    Modified Files:
>    	src/sys/sys: disklabel.h
>    Log Message:
>    Only include machine/disklabel.h if MAXPARTITIONS is undefined.
>    With care should allow sys/disklabel.h to be used in MI/host code.
> david,
> please back out this change and if you really want to make it,
> bring it up on tech-kern.  also, while there, please back out
> the changes to usr.sbin/installboot to use sys/disklabel.h.
> (why did you ignore sys/bootblock.h?)

Because the code needs to look at the netbsd disklabel - which is defined
(apart from its size) in sys/disklabel.h.

> you need to take a lot more care when making such changes to
> the system - they need wide testing, and these days, changing
> host tools means testing on a wide variety of host platforms.

The only way they can be tested is to commit the changes and fix
the fallout quickly, no one person can have access to all the variety
of host platforms.

There is a general problem if code needs to include target makefiles
when building tools - which I agree I've fallen foul of.


David Laight: