Subject: Re: CVS commit: src/sys/sys
To: David Laight <firstname.lastname@example.org>
From: Bill Studenmund <email@example.com>
Date: 11/06/2003 11:07:37
Content-Type: text/plain; charset=us-ascii
On Tue, Nov 04, 2003 at 04:19:52PM +0000, David Laight wrote:
> Module Name: src
> Committed By: dsl
> Date: Tue Nov 4 16:19:52 UTC 2003
> Modified Files:
> src/sys/sys: proc.h
> Log Message:
> Remove p_nras from struct proc - use LIST_EMPTY(&p->p_raslist) instead.
> Remove p_raslock and rename p_lwplock p_lock (one lock is enough).
> (pad fields left in struct proc to avoid kernel bump)
You changed field names and deleted one. You really should bump the
version. The point isn't just that you kept struct proc's layout the same,
it's that you renamed something.
While you've done an excelent job of maintaining binary compatability, you
have broken source compatability. The packages I'm familiar with that try=
to keep lkms and drivers up to date use defines based on kernel version.=20
This change makes it so that that behavior (defines) doesn't work.
I'd say just bump the kernel version.
If we're getting worried about too many letters, then we (the developers)=
should informally work on bunching changes together.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)
-----END PGP SIGNATURE-----