Subject: re: CVS commit: src/usr.sbin/installboot
To: David Laight <firstname.lastname@example.org>
From: matthew green <email@example.com>
Date: 11/03/2003 04:04:41
On Mon, Nov 03, 2003 at 01:24:21AM +0900, Izumi Tsutsui wrote:
> In article <firstname.lastname@example.org>
> email@example.com wrote:
> > for some platforms, it *must* be RAW_PART ('c'), but for some it can
> > be on a per-partition basis. i believe x86 is one of those.
On i386 it has to be the beginning of the BIOS boot partition.
That need not be at the start of (or even inside) the 'c' partition.
well, for i386, that'd be 'd', which i hope it fits inside :-) that's
why i said "RAW_PART" not just 'c'....
> Some platforms require to write some code in LABELSECTOR on installboot,
> but MD bounds_check_with_label() doesn't allow it unless RAW_PART
> is specified.
> (If RAW_PART is specified, bounds_check_with_label() is not called)
> On news68k, I changed bounds_check_with_label() to skip
> the check on securelevel == 0, but Christoph Badura suggested
> me to use proper ioctl() to write data in LABELSECTOR.
> I don't know what is the right solution, though.
ISTM that allowing writes to LABELSECTOR using RAW_PART is a bug!
installboot ought to be using the ioctl().
there always disklabel -[NW] (and whatever the ioctl's that these
call are ...) they should be used consistently on our platforms.