Subject: Re: CVS commit: src/libexec/comsat
To: Simon Burge <>
From: None <>
List: source-changes
Date: 09/19/2003 15:03:05
>I'm not sure I understand what actually changed here.  The old code did:
>	newsize = some expression;
>	buf = realloc(newsize);
>	if (buf == NULL)
>		exit();
>Now we say:
>	tmp buf = realloc(some expression);
>	if (tmp buf == NULL)
>		exit();
>	buf = tmp buf;
>	newsize = some expression;
>It seems to me that we've introduced extra complexity for absolutely no
>reason at all.  Because the program exits immediately in the failure
>case (without jumping through a pile of clean-up functions), there's
>no chance that an invalid buffer or buffersize will be used in further

	if we leave bad practice in code people would cut-and-paste it and use
	it, causing bad mistakes.  so i am being pedantic.