Subject: Re: CVS commit: src/crypto/dist/ssh
To: None <>
From: David Young <>
List: source-changes
Date: 09/16/2003 14:22:46
On Tue, Sep 16, 2003 at 01:22:59PM +0000, Christos Zoulas wrote:
> Module Name:	src
> Committed By:	christos
> Date:		Tue Sep 16 13:22:58 UTC 2003
> Modified Files:
> 	src/crypto/dist/ssh: buffer.c
> Log Message:
> Do not record expanded size before attempting to reallocate the associated
> memory. From OpenBSD, via FreeBSD.

Just in case this patch made anybody else scratch their head, the bug it
fixes seems to be that when xrealloc() fails in buffer_append_space(), it
calls fatal()->fatal_cleanup()->function pointer->buffer_free()->memset(),
which zeroes 32K bytes too many because the expanded size is already


David Young             OJC Technologies      Urbana, IL * (217) 278-3933