Subject: Re: CVS commit: src/sys/miscfs/kernfs
To: enami tsugutomo <enami@sm.sony.co.jp>
From: Daniel Carosone <dan@geek.com.au>
List: source-changes
Date: 09/10/2003 19:33:39
On Wed, Sep 10, 2003 at 05:54:55PM +0900, enami tsugutomo wrote:
> Daniel Carosone <dan@geek.com.au> writes:
> 
> > > Also, attempting to list either of the new ipsecs[ap]/ directories
> > > results in an instant panic, what looked like "page fault trap in
> > > supervisor mode" or something similar before the machine rebooted.
> 
> NULL pointer deref. introduced in rev. 1.92.  See kernfs_lookup() then
> you'll find kfs->kfs_kt is NULL for some kind of node.

It's not in the lookup code.  ls -l makes it panic, plain ls doesn't,
so it's in getattr. 

It's not new in 1.92, it's there in 1.91.

It's only in the ipsecsp dir, I was mistaken. ipsecsa dir is fine.

The code in Pipsecsp case of readdir is finding bogus SPD entries, it seems:

dan@tv [19:21][304]/kern# ls ipsecsp
16384 16385 16386 16387
dan@tv [19:23][305]/kern# setkey -DP
No SPD entries.

Interesting numbers :)

Probably the same error leads to them being found again when I later
getattr on them, rather than being rejected with ENOENT, but then
the garbage inside is used.

--
Dan.