Subject: Re: CVS commit: src/sbin/newfs
To: Jun-ichiro itojun Hagino <email@example.com>
From: David Laight <firstname.lastname@example.org>
Date: 09/04/2003 16:50:42
On Thu, Sep 04, 2003 at 03:30:38PM +0000, Jun-ichiro itojun Hagino wrote:
> Module Name: src
> Committed By: itojun
> Date: Thu Sep 4 15:30:38 UTC 2003
> Modified Files:
> src/sbin/newfs: mkfs.c
> Log Message:
> use arc4random(3). it is at least better than random(3)
> XXX masked topmost bit so that values don't go negative, is it the right thing
> to do?
It would be better to suggest these changes to someone who has been
looking at the sources recently, and knows what the numbers are for!
Did you consider, for instance, what happens when sysinst runs newfs?
- is /dev/urandom in the install kernels?
- is KERN_URND defined (and implemented?)
Actually maybe an in-kernel RC4 based random generater would be good
enough for many purposes - especially if clocked occaisonally just for
the hell of it, and provided some semi-random initialisation data can be
David Laight: email@example.com