Subject: Re: CVS commit: src/sbin/newfs
To: None <source-changes@NetBSD.org>
From: David Laight <email@example.com>
Date: 09/04/2003 09:29:11
> > src/sbin/newfs: mkfs.c
> > Log Message:
> > Randomise di_igen for the first 2 blocks of inodes for non-UFS2 filesystems.
> > Randomise di_igen for "/" (and lost+found) for UFS2 filesystems.
> > Ensure nothing from the lost+found inode leaks into the / inode.
> Uhm, where was this discussed? You've taken the combination of a
> deterministic process + tool (fsirand) and forced them together with no
> options. While it may be time to have inode # randomization the default,
> it should: 1) be discussed, and 2) be controlable.
Actually I didn't, I just fixed the existing code so that it actually did
what it was trying to do!
This all came in with the UFS2 support, however it was using cg_initediblk
to determine how many of the inodes to initialise (ie randomise di_gen
and zero) - which got zeroed for UFS1. The rest of the inodes only get
initialised for UFS1 and were being given a random di_gen.
This fixed showed that when the directory inodes are written they (again)
picked up a zero di_gen.
David Laight: firstname.lastname@example.org