Subject: CVS commit: src/sys/dev/usb
To: None <>
From: Charles M. Hannum <>
List: source-changes
Date: 09/04/2003 00:03:00
Module Name:	src
Committed By:	mycroft
Date:		Thu Sep  4 00:03:00 UTC 2003

Modified Files:
	src/sys/dev/usb: umass.c

Log Message:
Well, this is bloody obscure...
My Imation USB FlashGO! adapter responds to a Get Max Lun request with a
stall.  With uhci, this does the expected thing.  With ohci, it was returning
a "data underrun" error because we weren't setting "buffer rounding" (i.e.
USBD_SHORT_XFER_OK), and the underrun was taking priority.  This happened with
both the ohci in a Mac cube and the builtin ohci on the S3C2410.

So, set USBD_SHORT_XFER_OK on the Get Max Lun.  Now I get a stall reported and
umass attaches correctly.

To generate a diff of this commit:
cvs rdiff -r1.96 -r1.97 src/sys/dev/usb/umass.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.