Subject: Re: CVS commit: src
To: None <source-changes@netbsd.org>
From: Jesse Off <joff@stchome.com>
List: source-changes
Date: 06/16/2003 08:29:25
I think part of the problem is that applications that use rcmd() don't get
a socket fd back like the manpage says, but a pipe to a /bin/rcmd process.
rdist can't setsockopt TCP_NODELAY on that pipe.  I'm not sure the logic
behind that, but trust that there is some reason it was done that way.

One could, however, move the setting of the TCP_NODELAY in rshd to the end
process (e.g. rdist -Server) since it looks like the server process does
get the real socket.  Would this be more appropriate?

Note that rlogin wasn't affected by this change, just rsh, rcmd, and rshd.

//Jesse Off


>   matthew green <mrg@eterna.com.au> writes:
>   >    Jesse Off <joff@netbsd.org> writes:
>   >    > Module Name:	src
>   >    > Committed By:	joff
>   >    > Date:		Sat Jun 14 22:43:33 UTC 2003
>   >    >
>   >    > Modified Files:
>   >    > 	src/libexec/rshd: rshd.c
>   >    > 	src/usr.bin/rsh: rsh.c
>   >    >
>   >    > Log Message:
>   >    > use TCP_NODELAY
>   >
>   >    Is that correct? I'd say it isn't -- if anything was built for
>Nagle's
>   >    Algorithm it is rsh or telnet. Who reviewed this change?
>   >
>   > rlogin or telnet you mean?
>
>   Yah, but rlogin is just a front for rsh I believe.
>
>
>actually, rsh without a command is a frontend for rlogin...