Subject: Re: CVS commit: src/usr.bin/menuc
To: David Laight <david@l8s.co.uk>
From: Luke Mewburn <lukem@netbsd.org>
List: source-changes
Date: 05/09/2003 22:26:18
On Fri, May 09, 2003 at 01:23:24PM +0100, David Laight wrote:
  | > 
  | > Log Message:
  | > Revert part of previous, and remove "const" from "char *opt_name" and
  | > "char *title", since it causes compile problems for the only program
  | > that uses menuc (sysinst).
  | 
  | I need that so that I can put a MSG_xxx string into the menu.
  | These are (const char *)n for small integer n.
  |
  | I actually commited the required change to sysint...

I had completely up-to-date source, and a build of the i386 ramdisks
still failed because the timezone code in util.c mallocs menu_ents,
and then fails to compile:
	for(n=0; n < nfiles; n++)
		free(tz_menu[n].opt_name);
because you can't free() "const char *optname".

Multiple other people hit this problem as well.