Subject: build error [was Re: CVS commit: src]
To: None <bjh21@netbsd.org>
From: Darrin B. Jewell <dbj@netbsd.org>
List: source-changes
Date: 05/05/2003 15:10:07
I'm seeing the following warning/error when I build libc:

/Volumes/Data/work/trunkwork/src/lib/libc/net/inet_lnaof.c(66): warning: conversion from 'unsigned long' may lose accuracy [132]
/Volumes/Data/work/trunkwork/src/lib/libc/net/inet_lnaof.c(68): warning: conversion from 'unsigned long' may lose accuracy [132]
/Volumes/Data/work/trunkwork/src/lib/libc/net/inet_lnaof.c(70): warning: conversion from 'unsigned long' may lose accuracy [132]
*** Error code 1

I suspect it is related to this commit.

Could you please look into it?  Let me know if you need more information.

Darrin

Ben Harris <bjh21@netbsd.org> writes:

> Module Name:	src
> Committed By:	bjh21
> Date:		Mon May  5 13:56:15 UTC 2003
> 
> Modified Files:
> 	src/include/arpa: inet.h
> 	src/lib/libc/net: inet_lnaof.c inet_makeaddr.c inet_netof.c
> 	    inet_network.c inet_pton.c
> 
> Log Message:
> Fix the signatures of inet_addr(), inet_lnaof(), inet_makeaddr(), inet_netof(),
> and inet_network() to match XNS and (where applicable) POSIX.  This is largely
> just the replacement of unsigned long with in_addr_t.
> 
> This constitutes a small ABI change on sh5, but scw (sh5 portmaster) thinks
> that both the users of that port will be able to cope.  kleink claims the
> change is ABI-neutral on other LP64 ports, and it's a no-op on ILP32 ports.
> Hence, I'm doing it this way and avoiding the whole __RENAME dance.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.14 -r1.15 src/include/arpa/inet.h
> cvs rdiff -r1.7 -r1.8 src/lib/libc/net/inet_lnaof.c \
>     src/lib/libc/net/inet_netof.c
> cvs rdiff -r1.10 -r1.11 src/lib/libc/net/inet_makeaddr.c
> cvs rdiff -r1.14 -r1.15 src/lib/libc/net/inet_network.c
> cvs rdiff -r1.17 -r1.18 src/lib/libc/net/inet_pton.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.