Subject: Re: CVS commit: syssrc/sys/dev/ic
To: None <jmc@netbsd.org>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: source-changes
Date: 12/08/2002 13:30:15
In article <20021208010936.EDD4EB42C@cvs.netbsd.org>
jmc@netbsd.org wrote:

> Module Name:	syssrc
> Committed By:	jmc
> Date:		Sun Dec  8 01:09:36 UTC 2002
> 
> Modified Files:
> 	syssrc/sys/dev/ic: iha.c ihareg.h
> 
> Log Message:
> Put back MSG_IDENTIFY_LUNMASK (renamed to just be within the IHA namespace.
> The definitions were not the same between the scsi_messages file and this
> definition so simply removing it here and letting the other one be used
> results in incorrect behavior (regardless of whether it made the code
> compile....)

Do you actually see any incorrect behavior?

Anyway, I think we should fix MSG_IDENTIFY_LUNMASK definition
in scsi_message.h because bit5 in identify message is LUNTAR,
and bit4 and bit3 are reserved (i.e. zero).
http://www.danbbs.dk/~dino/SCSI/SCSI2-06.html#6.6.7

OpenBSD defines MSG_IDENTIFY_LUNMASK as 0x1f, not 0x3f.
http://www.openbsd.org/cgi-bin/cvsweb/src/sys/scsi/scsi_message.h
---
Izumi Tsutsui
tsutsui@ceres.dti.ne.jp