Subject: CVS commit: basesrc/usr.sbin/sushi
To: None <firstname.lastname@example.org>
From: Christos Zoulas <email@example.com>
Date: 04/02/2002 21:59:55
Module Name: basesrc
Committed By: christos
Date: Tue Apr 2 18:59:55 UTC 2002
XXX: this code needs a lot more cleanup... There is no clear malloc/free
policy and the data dependent initialization is very fragile. I.e.
the code assumes because the data entry is of type foo, it has
initialized certain fields and others not.
- make sure list is not NULL before you use it.
- don't realloc on every loop iteration!
- don't increment i when there are short lines; leads to uninitialized
list[i] entries [fixes bills' core-dump, hi bill!]
To generate a diff of this commit:
cvs rdiff -r1.20 -r1.21 basesrc/usr.sbin/sushi/scanform.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.