Subject: Re: CVS commit: syssrc
To: John Hawkinson <jhawk@MIT.EDU>
From: None <email@example.com>
Date: 05/16/2001 00:38:55
All other DEBUG options are set via
try and set PCMCIADEBUG like that in a config file.
It'll bail out with a redefinition error. That's
1. Non obvious as hell
2. Completely opposite of how every other standard debug #define gets set
This should be setup the same as any other debug arguments. If you want to
have debug turned on for something, set it via an option in the conf file.
Otherwise the extra code shouldn't even be generated.
Past that I agree with being able to set the check var via ddb. But this all
goes back to DEBUG not getting set in GENERIC builds which this violates the
premise of being able to control.
>Please add a doc/CHANGES entry for this.
>I'm not sure I agree with you, though.
>It can be very useful to be able to turn this on in ddb,
>especially in INSTALL kernels, etc.
>In fact, I think maybe you should revert it.
>Can you offer a rationale better than cleanliness
>to go against the inconvenience?
>| Module Name: syssrc
>| Committed By: jmc
>| Date: Sun May 13 04:23:46 UTC 2001
>| Modified Files:
>| syssrc/sys/dev/pcmcia: pcmcia.c
>| Log Message:
>| Turn off PCMCIADEBUG by default. This should get set with options in a config file
>| To generate a diff of this commit:
>| cvs rdiff -r1.24 -r1.25 syssrc/sys/dev/pcmcia/pcmcia.c
>| Please note that diffs are not public domain; they are subject to the
>| copyright notices on the relevant files.