Subject: Re: CVS commit: syssrc
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Jason R Thorpe <thorpej@zembu.com>
List: source-changes
Date: 02/23/2001 17:19:11
On Sat, Feb 24, 2001 at 10:12:04AM +0900, Izumi Tsutsui wrote:

 > In <20010223235748.766D0B00B@cvs.netbsd.org>
 > mjacob@netbsd.org wrote:
 > 
 > > Modified Files:
 > > 	syssrc/sys/dev/sbus: isp_sbus.c
 > > 
 > > Log Message:
 > > Add missing BUS_DMA_COHERENT to bus_dmamap_load_raw calls for request
 > > and response queues- this makes this work on UltraSparc now.
 > 
 > Can bus_dmamap_load*() functions take BUS_DMA_COHERENT flag?
 > Isn't it valid for only bus_dmamem_[m]map() ?
 > Anyway BUS_DMA_COHERENT flag is just a hint,
 > so it should not be "required", I think.
 > (bus_dmamap_sync() is missing in some place?)

Izumi is correct -- BTW, since all NetBSD platforms that use this
driver support bus_dma, how about putting all the bus_dma stuff into
isp_netbsd.c?

-- 
        -- Jason R. Thorpe <thorpej@zembu.com>