Subject: Re: CVS commit: syssrc
To: None <jhawk@MIT.EDU>
From: Noriyuki Soda <soda@sra.co.jp>
List: source-changes
Date: 08/03/2000 14:23:26
> | Modified Files:
> | 	  syssrc/sys/arch/i386/pci: pci_addr_fixup.c
> | 
> | Log Message:
> | fix oversight introduced in previous my commmitment (revision 1.4),
> | pointed out by Michael Shalayeff <mickey@openbsd.org>.
> | 
> | To generate a diff of this commit:
> | cvs rdiff -r1.5 -r1.6 syssrc/sys/arch/i386/pci/pci_addr_fixup.c
> 
> This seems backwards to me. Are you certain it is correct?

Yes.
BTW, you are not first person who ask this (actually 3rd person :))

> Should it not still test "if (pcibiosverbose)" not "if (!pcibiosverbose)"?

If pcibiosverbose == 1, more detailed information (including new
address) is printed in pciaddr_resource_allocate() and 
pci_addr_resource_manage(), so this message is not needed.
--
soda