Subject: CVS commit: syssrc
To: None <firstname.lastname@example.org>
From: Scott Reynolds <email@example.com>
Date: 03/06/2000 22:35:24
Module Name: syssrc
Committed By: scottr
Date: Tue Mar 7 06:35:24 UTC 2000
Low-level drivers, like the Power Manager driver, can get us into a major
funk when they misbehave and give us unexpected results. Specifically:
- Don't assume that the first free slot is at the top of the table if
we can't find one.
- Don't increment ADBNumDevices when backfilling "holes" left by devices
that didn't respond to a TALK R3 during the initial device scan.
- Don't assume that an address reassignment worked; make sure something
responds on the new address before plowing forward.
- If after device reassignment there are no free slots, make sure to
indicate this fact.
- Failing all else, handle the situation where we run out of slots in
the device table -- which now should "never" happen -- gracefully.
While the Power Manager driver still sometimes misbehaves, it shouldn't
cause the system to crash/hang due to us walking off the end of the
To generate a diff of this commit:
cvs rdiff -r1.38 -r1.39 syssrc/sys/arch/mac68k/dev/adb_direct.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.