Subject: Re: CVS commit: basesrc
To: Assar Westerlund <firstname.lastname@example.org>
From: Jun-ichiro itojun Hagino <email@example.com>
Date: 12/06/1999 09:48:54
>> Modified Files:
>> basesrc/usr.bin/telnet: commands.c
>> Log Message:
>> clarify getaddrinfo() loop. try to contact all possible addresses
>> unless we experience fatal error.
>> XXX changed location of setuid(getuid()), may need someone's review.
>I think getting rid of all the setuid(getuid()) is the right thing to
>do. I don't see why you would want telnet to be installed setuid and
>I would not trust it being setuid.
setuid(getuid()) was there before I work on it (if I remember
correctly), and telnet(1) is NOT a setuid'ed program.
I wonder why it is here.