Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src-draft/trunk]: src/sys/dev/usb Cosmetic cleanup.



details:   https://anonhg.NetBSD.org/src-all/rev/18c4bbcf1ebc
branches:  trunk
changeset: 377860:18c4bbcf1ebc
user:      Martin Husemann <martin%NetBSD.org@localhost>
date:      Mon Dec 14 15:25:56 2020 +0100

description:
Cosmetic cleanup.

Remove some accidently commited debug printfs, whitespace.
Improve a KASSERT my moving to KASSERTMSG.

diffstat:

 sys/dev/usb/if_urtwn.c |  8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diffs (40 lines):

diff -r b27c6aaafe69 -r 18c4bbcf1ebc sys/dev/usb/if_urtwn.c
--- a/sys/dev/usb/if_urtwn.c    Thu Dec 10 18:26:08 2020 +0100
+++ b/sys/dev/usb/if_urtwn.c    Mon Dec 14 15:25:56 2020 +0100
@@ -3025,9 +3025,8 @@ urtwn_txeof(struct usbd_xfer *xfer, void
        }
 
        if_statinc(ifp, if_opackets);
-       urtwn_start(sc); 
+       urtwn_start(sc);
        splx(s);
-
 }
 
 static int
@@ -3310,7 +3309,7 @@ urtwn_start(struct urtwn_softc *sc)
                        break;
 
                ni = M_GETCTX(m, struct ieee80211_node *);
-               KASSERT(ni != NULL);
+               KASSERTMSG(ni != NULL, "wifi mbuf w/o node: %p", m);
                M_CLEARCTX(m);
                vap = ni->ni_vap;
 
@@ -3619,8 +3618,6 @@ urtwn_transmit(struct ieee80211com *ic, 
 {
        struct urtwn_softc *sc = ic->ic_softc;
        int s;
-       // size_t pktlen = m->m_pkthdr.len;
-       // bool mcast = (m->m_flags & M_MCAST) != 0;
 
        DPRINTFN(DBG_FN, ("%s: %s\n",device_xname(sc->sc_dev), __func__));
 
@@ -3687,7 +3684,6 @@ urtwn_raw_xmit(struct ieee80211_node *ni
 
        error = urtwn_tx(sc, m, ni, data);
        if (error != 0) {
-               printf("ERROR3\n");
                if_statinc(vap->iv_ifp, if_oerrors);
        } else {
                sc->tx_timer = 5;



Home | Main Index | Thread Index | Old Index