Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-9]: src/sys/arch/x86/pci Pull up following revision(s) (requested...



details:   https://anonhg.NetBSD.org/src/rev/ed211bff0803
branches:  netbsd-9
changeset: 376517:ed211bff0803
user:      martin <martin%NetBSD.org@localhost>
date:      Wed Jun 21 18:56:58 2023 +0000

description:
Pull up following revision(s) (requested by msaitoh in ticket #1644):

        sys/arch/x86/pci/amdsmn.c: revision 1.16
        sys/arch/x86/pci/amdzentemp.c: revision 1.17
        sys/arch/x86/pci/amdzentemp.c: revision 1.18

Reduce diff against DragonFly. No functional change.
amdsmn(4),amdzentemp(4): Add Zen3+ Rembrandt(19h/4xh) & Zen4 Genoa(19h/1xh).

diffstat:

 sys/arch/x86/pci/amdsmn.c     |  16 ++++++++++++--
 sys/arch/x86/pci/amdzentemp.c |  45 ++++++++++++++++++++++++------------------
 2 files changed, 39 insertions(+), 22 deletions(-)

diffs (170 lines):

diff -r bc69f8e4b9a5 -r ed211bff0803 sys/arch/x86/pci/amdsmn.c
--- a/sys/arch/x86/pci/amdsmn.c Wed Jun 21 16:06:14 2023 +0000
+++ b/sys/arch/x86/pci/amdsmn.c Wed Jun 21 18:56:58 2023 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: amdsmn.c,v 1.5.2.3 2022/10/11 18:16:20 martin Exp $    */
+/*     $NetBSD: amdsmn.c,v 1.5.2.4 2023/06/21 18:56:58 martin Exp $    */
 
 /*-
  * Copyright (c) 2017, 2019 Conrad Meyer <cem%FreeBSD.org@localhost>
@@ -29,7 +29,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: amdsmn.c,v 1.5.2.3 2022/10/11 18:16:20 martin Exp $ ");
+__KERNEL_RCSID(0, "$NetBSD: amdsmn.c,v 1.5.2.4 2023/06/21 18:56:58 martin Exp $ ");
 
 /*
  * Driver for the AMD Family 15h (model 60+) and 17h CPU
@@ -93,7 +93,17 @@ static const struct pciid {
                .amdsmn_data_reg = F17H_SMN_DATA_REG,
        },
        {
-               .amdsmn_deviceid = PCI_PRODUCT_AMD_F17_7X_RC,
+               .amdsmn_deviceid = PCI_PRODUCT_AMD_F17_7X_RC, /* or F19_0X */
+               .amdsmn_addr_reg = F17H_SMN_ADDR_REG,
+               .amdsmn_data_reg = F17H_SMN_DATA_REG,
+       },
+       {
+               .amdsmn_deviceid = PCI_PRODUCT_AMD_F17_AX_RC, /* or F19_4X */
+               .amdsmn_addr_reg = F17H_SMN_ADDR_REG,
+               .amdsmn_data_reg = F17H_SMN_DATA_REG,
+       },
+       {
+               .amdsmn_deviceid = PCI_PRODUCT_AMD_F19_1X_RC,
                .amdsmn_addr_reg = F17H_SMN_ADDR_REG,
                .amdsmn_data_reg = F17H_SMN_DATA_REG,
        },
diff -r bc69f8e4b9a5 -r ed211bff0803 sys/arch/x86/pci/amdzentemp.c
--- a/sys/arch/x86/pci/amdzentemp.c     Wed Jun 21 16:06:14 2023 +0000
+++ b/sys/arch/x86/pci/amdzentemp.c     Wed Jun 21 18:56:58 2023 +0000
@@ -1,4 +1,4 @@
-/*      $NetBSD: amdzentemp.c,v 1.9.2.3 2023/01/23 12:27:33 martin Exp $ */
+/*      $NetBSD: amdzentemp.c,v 1.9.2.4 2023/06/21 18:56:58 martin Exp $ */
 /*      $OpenBSD: kate.c,v 1.2 2008/03/27 04:52:03 cnst Exp $   */
 
 /*
@@ -53,7 +53,7 @@
 
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: amdzentemp.c,v 1.9.2.3 2023/01/23 12:27:33 martin Exp $ ");
+__KERNEL_RCSID(0, "$NetBSD: amdzentemp.c,v 1.9.2.4 2023/06/21 18:56:58 martin Exp $ ");
 
 #include <sys/param.h>
 #include <sys/bus.h>
@@ -74,7 +74,6 @@
 #include "amdsmn.h"
 
 #define        AMD_CURTMP_RANGE_ADJUST 49000000        /* in microKelvins (ie, 49C) */
-#define        AMD_CURTMP_RANGE_CHECK  __BIT(19)
 #define        F10_TEMP_CURTMP         __BITS(31,21)   /* XXX same as amdtemp.c */
 #define        F10_TEMP_CURTMP_MASK    0x7ff
 #define        F15M60_CURTMP_TJSEL     __BITS(17,16)
@@ -96,14 +95,7 @@
  * to -49..206C.
  */
 #define        AMD_17H_CUR_TMP                 0x59800
-
-/*
- * The following register set was discovered experimentally by Ondrej Čerman
- * and collaborators, but is not (yet) documented in a PPR/OSRR (other than
- * the M70H PPR SMN memory map showing [0x59800, +0x314] as allocated to
- * SMU::THM).  It seems plausible and the Linux sensor folks have adopted it.
- */
-#define        AMD_17H_CCD_TMP_BASE            0x59954
+#define        AMD_17H_CUR_TMP_RANGE_SEL       __BIT(19)
 #define        AMD_17H_CCD_TMP_VALID           __BIT(11)
 
 struct amdzentemp_softc {
@@ -114,7 +106,7 @@ struct amdzentemp_softc {
        size_t sc_sensor_len;
        size_t sc_numsensors;
        int32_t sc_offset;
-       uint32_t sc_ccd_tmp_base;
+       int32_t sc_ccd_offset;
 };
 
 enum {
@@ -129,6 +121,10 @@ enum {
        CCD5,
        CCD6,
        CCD7,
+       CCD8,
+       CCD9,
+       CCD10,
+       CCD11,
        CCD_MAX,
        NUM_CCDS = CCD_MAX - CCD_BASE
 };
@@ -339,14 +335,16 @@ amdzentemp_family17_refresh(struct sysmo
                        edata->state = ENVSYS_SINVALID;
                        return;
                }
-               minus49 = (temp & AMD_CURTMP_RANGE_CHECK) ? true : false;
+               minus49 = (temp & AMD_17H_CUR_TMP_RANGE_SEL) ?
+                   true : false;
                temp = __SHIFTOUT(temp, F10_TEMP_CURTMP);
                break;
        case CCD_BASE ... (CCD_MAX - 1):
                /* Tccd */
                i = edata->private - CCD_BASE;
                error = amdsmn_read(sc->sc_smn,
-                   sc->sc_ccd_tmp_base + (i * sizeof(temp)), &temp);
+                   AMD_17H_CUR_TMP + sc->sc_ccd_offset + (i * sizeof(temp)),
+                   &temp);
                if (error || !ISSET(temp, AMD_17H_CCD_TMP_VALID)) {
                        edata->state = ENVSYS_SINVALID;
                        return;
@@ -372,6 +370,8 @@ amdzentemp_probe_ccd_sensors17h(struct a
 {
        int maxreg;
 
+       sc->sc_ccd_offset = 0x154;
+
        switch (model) {
        case 0x00 ... 0x2f: /* Zen1, Zen+ */
                maxreg = 4;
@@ -399,12 +399,21 @@ amdzentemp_probe_ccd_sensors19h(struct a
        case 0x00 ... 0x0f: /* Zen3 EPYC "Milan" */
        case 0x20 ... 0x2f: /* Zen3 Ryzen "Vermeer" */
        case 0x50 ... 0x5f: /* Zen3 Ryzen "Cezanne" */
+               sc->sc_ccd_offset = 0x154;
                maxreg = 8;
                break;
        case 0x60 ... 0x6f: /* Zen4 Ryzen "Raphael" */
-               sc->sc_ccd_tmp_base = 0x59b08;
+               sc->sc_ccd_offset = 0x308;
                maxreg = 8;
                break;
+       case 0x40 ... 0x4f: /* Zen3+ "Rembrandt" */
+               sc->sc_ccd_offset = 0x300;
+               maxreg = 8;
+               break;
+       case 0x10 ... 0x1f: /* Zen4 "Genoa" */
+               sc->sc_ccd_offset = 0x300;
+               maxreg = 12;
+               break;
        default:
                aprint_error_dev(sc->sc_dev,
                    "Unrecognized Family 19h Model: %02xh\n", model);
@@ -419,9 +428,6 @@ amdzentemp_probe_ccd_sensors(struct amdz
 {
        int nccd;
 
-       /* Set default CCD temp sensor base address. */
-       sc->sc_ccd_tmp_base = 0x59954;
-
        switch (family) {
        case 0x17:
                nccd = amdzentemp_probe_ccd_sensors17h(sc, model);
@@ -446,7 +452,8 @@ amdzentemp_setup_ccd_sensors(struct amdz
 
        for (i = 0; i < sc->sc_numsensors - 1; i++) {
                error = amdsmn_read(sc->sc_smn,
-                   sc->sc_ccd_tmp_base + (i * sizeof(temp)), &temp);
+                   AMD_17H_CUR_TMP + sc->sc_ccd_offset + (i * sizeof(temp)),
+                   &temp);
                if (error || !ISSET(temp, AMD_17H_CCD_TMP_VALID))
                        continue;
 


Home | Main Index | Thread Index | Old Index