[src/trunk]: src/sys/kern Don't forget to free the cred we just held.

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/fdb72b9fce01
branches:  trunk
changeset: 369940:fdb72b9fce01
user:      christos <christos%NetBSD.org@localhost>
date:      Fri Sep 09 14:30:17 2022 +0000

description:
Don't forget to free the cred we just held.
Thanks to Chris J-D (chris at accessvector dot net)
While here, de-duplicate the mutex exit sequence.

diffstat:

 sys/kern/kern_core.c |  24 ++++++++++--------------
 1 files changed, 10 insertions(+), 14 deletions(-)

diffs (80 lines):

diff -r 5dd902c763d4 -r fdb72b9fce01 sys/kern/kern_core.c
--- a/sys/kern/kern_core.c      Fri Sep 09 14:16:16 2022 +0000
+++ b/sys/kern/kern_core.c      Fri Sep 09 14:30:17 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: kern_core.c,v 1.35 2021/06/29 22:40:53 dholland Exp $  */
+/*     $NetBSD: kern_core.c,v 1.36 2022/09/09 14:30:17 christos Exp $  */
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1991, 1993
@@ -37,7 +37,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_core.c,v 1.35 2021/06/29 22:40:53 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_core.c,v 1.36 2022/09/09 14:30:17 christos Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_execfmt.h"
@@ -121,7 +121,7 @@
        struct vnode            *vp;
        struct proc             *p;
        struct vmspace          *vm;
-       kauth_cred_t            cred;
+       kauth_cred_t            cred = NULL;
        struct pathbuf          *pb;
        struct vattr            vattr;
        struct coredump_iostate io;
@@ -145,9 +145,7 @@
        if (USPACE + ctob(vm->vm_dsize + vm->vm_ssize) >=
            p->p_rlimit[RLIMIT_CORE].rlim_cur) {
                error = EFBIG;          /* better error code? */
-               mutex_exit(p->p_lock);
-               mutex_exit(&proc_lock);
-               goto done;
+               goto release;
        }
 
        /*
@@ -164,9 +162,7 @@
        if (p->p_flag & PK_SUGID) {
                if (!security_setidcore_dump) {
                        error = EPERM;
-                       mutex_exit(p->p_lock);
-                       mutex_exit(&proc_lock);
-                       goto done;
+                       goto release;
                }
                pattern = security_setidcore_path;
        }
@@ -180,11 +176,8 @@
        error = coredump_buildname(p, name, pattern, MAXPATHLEN);
        mutex_exit(&lim->pl_lock);
 
-       if (error) {
-               mutex_exit(p->p_lock);
-               mutex_exit(&proc_lock);
-               goto done;
-       }
+       if (error)
+               goto release;
 
        /*
         * On a simple filename, see if the filesystem allow us to write
@@ -198,6 +191,7 @@
                        error = EPERM;
        }
 
+release:
        mutex_exit(p->p_lock);
        mutex_exit(&proc_lock);
        if (error)
@@ -284,6 +278,8 @@
        if (error == 0)
                error = error1;
 done:
+       if (cred != NULL)
+               kauth_cred_free(cred);
        if (name != NULL)
                PNBUF_PUT(name);
        return error;