Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/powerpc/fpu fpu_compare(): Fix inverted logic and c...



details:   https://anonhg.NetBSD.org/src/rev/5a4ed9704007
branches:  trunk
changeset: 369929:5a4ed9704007
user:      rin <rin%NetBSD.org@localhost>
date:      Thu Sep 08 15:21:50 2022 +0000

description:
fpu_compare(): Fix inverted logic and comment it out for now.

VXVC is raised for SNaN if VE == 0.

As we still do not support enabled exception bits, comment out
this if statement for consistency at the moment.

diffstat:

 sys/arch/powerpc/fpu/fpu_compare.c |  9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diffs (30 lines):

diff -r f8ddef828002 -r 5a4ed9704007 sys/arch/powerpc/fpu/fpu_compare.c
--- a/sys/arch/powerpc/fpu/fpu_compare.c        Thu Sep 08 07:05:42 2022 +0000
+++ b/sys/arch/powerpc/fpu/fpu_compare.c        Thu Sep 08 15:21:50 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: fpu_compare.c,v 1.6 2022/09/04 13:14:57 rin Exp $ */
+/*     $NetBSD: fpu_compare.c,v 1.7 2022/09/08 15:21:50 rin Exp $ */
 
 /*
  * Copyright (c) 1992, 1993
@@ -48,7 +48,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: fpu_compare.c,v 1.6 2022/09/04 13:14:57 rin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: fpu_compare.c,v 1.7 2022/09/08 15:21:50 rin Exp $");
 
 #include <sys/types.h>
 
@@ -95,7 +95,10 @@
                if (ISSNAN(a) || ISSNAN(b))
                        cc |= FPSCR_VXSNAN;
                if (ordered) {
-                       if (fe->fe_fpscr & FPSCR_VE || ISQNAN(a) || ISQNAN(b))
+#ifdef notyet /* XXXRO */
+                       if ((fe->fe_fpscr & FPSCR_VE) == 0 ||
+                           ISQNAN(a) || ISQNAN(b))
+#endif
                                cc |= FPSCR_VXVC;
                }
                goto done;



Home | Main Index | Thread Index | Old Index