Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/libc/arch/powerpc/string Obsolete hack for evbppc to rep...



details:   https://anonhg.NetBSD.org/src/rev/8a56c7c12ad2
branches:  trunk
changeset: 366552:8a56c7c12ad2
user:      rin <rin%NetBSD.org@localhost>
date:      Mon May 30 14:43:37 2022 +0000

description:
Obsolete hack for evbppc to replace memcmp(9), memcpy(9), and memmove(9)
with strictly-aligned versions.

Now all 32-bit powerpc ports share the same libc binary.

This change together with the preceding similar change in libkern slightly
improve performance for DHT (ibm4xx/405GP) and RB800 (MPC8533E).

See changes in bytebench scores:

- DHT   https://gist.github.com/rokuyama/301063355de9733bea515b84ef574c0a
- RB800 https://gist.github.com/rokuyama/60ad665d367d6d110b79ec44707f39ff

Improvements may be negligible, but this does not cause performance
regressions at least.

This hack was for 403, but unaligned memory access is now emulated by
kernel. This should result in serious performance regression for 403.
We will provide strictly-aligned versions by ld.so.conf.

diffstat:

 lib/libc/arch/powerpc/string/Makefile.inc |  13 ++-----------
 1 files changed, 2 insertions(+), 11 deletions(-)

diffs (22 lines):

diff -r b4f551373d77 -r 8a56c7c12ad2 lib/libc/arch/powerpc/string/Makefile.inc
--- a/lib/libc/arch/powerpc/string/Makefile.inc Mon May 30 14:28:31 2022 +0000
+++ b/lib/libc/arch/powerpc/string/Makefile.inc Mon May 30 14:43:37 2022 +0000
@@ -1,16 +1,7 @@
-#      $NetBSD: Makefile.inc,v 1.15 2021/07/26 12:49:13 rin Exp $
+#      $NetBSD: Makefile.inc,v 1.16 2022/05/30 14:43:37 rin Exp $
 
 SRCS+=  bzero.S ffs.S strlen.S
 NO_SRCS+= memset.S
 
-# XXX
-# Disable asm versions that use unaligned memory access and thus break 403.
-.if ${MACHINE} == "evbppc"
-.  for name in bcopy memcmp memcpy memmove
-.    for suffix in o po pico go d
-${name}.${suffix}: ${name}.c
-.    endfor
-.  endfor
-.else
+# with unaligned memory access
 SRCS+= memcmp.S bcopy.S memcpy.S memmove.S
-.endif



Home | Main Index | Thread Index | Old Index