[.joined/src/trunk]: .joined/src/sys/arch/arm/pic arm: No #if DIAGNOSTIC need...

[riastradh <riastradh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/.joined/src/rev/9f0b23594826
branches:  trunk
changeset: 359401:9f0b23594826
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sun Jan 02 11:17:39 2022 +0000

description:
arm: No #if DIAGNOSTIC needed any more.

Compiler can (and gcc does) flush call to strlen when the result is
unused, so no performance impact here.

diffstat:

 sys/arch/arm/pic/pic.c |  6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diffs (28 lines):

diff -r a93ce55b7c56 -r 9f0b23594826 sys/arch/arm/pic/pic.c
--- a/sys/arch/arm/pic/pic.c    Sun Jan 02 03:46:40 2022 +0000
+++ b/sys/arch/arm/pic/pic.c    Sun Jan 02 11:17:39 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pic.c,v 1.78 2021/12/21 07:11:02 skrll Exp $   */
+/*     $NetBSD: pic.c,v 1.79 2022/01/02 11:17:39 riastradh Exp $       */
 
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
 #include "opt_multiprocessor.h"
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pic.c,v 1.78 2021/12/21 07:11:02 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pic.c,v 1.79 2022/01/02 11:17:39 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/atomic.h>
@@ -575,9 +575,7 @@
        KASSERT(pcpu->pcpu_evs != NULL);
 
 #define        PCPU_NAMELEN    32
-#ifdef DIAGNOSTIC
        const size_t namelen = strlen(pic->pic_name) + 4 + strlen(ci->ci_data.cpu_name);
-#endif
 
        KASSERT(namelen < PCPU_NAMELEN);
        pcpu->pcpu_name = kmem_alloc(PCPU_NAMELEN, KM_SLEEP);