Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/jdolecek-ncqfixes]: src/sys/dev/ic add C_TIMEOUT KASSERT() on fail path ...



details:   https://anonhg.NetBSD.org/src/rev/cbc0f09dd103
branches:  jdolecek-ncqfixes
changeset: 1025098:cbc0f09dd103
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Sat Oct 13 07:23:34 2018 +0000

description:
add C_TIMEOUT KASSERT() on fail path of mvsata_bio_poll() for clarity

diffstat:

 sys/dev/ic/mvsata.c |  8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diffs (30 lines):

diff -r 18413d6d6c00 -r cbc0f09dd103 sys/dev/ic/mvsata.c
--- a/sys/dev/ic/mvsata.c       Thu Oct 11 20:57:51 2018 +0000
+++ b/sys/dev/ic/mvsata.c       Sat Oct 13 07:23:34 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mvsata.c,v 1.41.2.7 2018/10/11 20:57:51 jdolecek Exp $ */
+/*     $NetBSD: mvsata.c,v 1.41.2.8 2018/10/13 07:23:34 jdolecek Exp $ */
 /*
  * Copyright (c) 2008 KIYOHARA Takashi
  * All rights reserved.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mvsata.c,v 1.41.2.7 2018/10/11 20:57:51 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mvsata.c,v 1.41.2.8 2018/10/13 07:23:34 jdolecek Exp $");
 
 #include "opt_mvsata.h"
 
@@ -1281,8 +1281,10 @@
                chp->ch_flags &= ~ATACH_DMA_WAIT;
        }
 
-       if ((xfer->c_bio.flags & ATA_ITSDONE) == 0)
+       if ((xfer->c_bio.flags & ATA_ITSDONE) == 0) {
+               KASSERT(xfer->c_flags & C_TIMEOU);
                mvsata_bio_intr(chp, xfer, 0);
+       }
 }
 
 static int



Home | Main Index | Thread Index | Old Index