[src/trunk]: src/usr.bin/xlint/lint1 lint: improve output format for internal...

[rillig <rillig%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/bd6606586a56
branches:  trunk
changeset: 1019959:bd6606586a56
user:      rillig <rillig%NetBSD.org@localhost>
date:      Fri Mar 26 21:05:27 2021 +0000

description:
lint: improve output format for internal errors

The new format follows the common conventions for file locations and
allows quick navigation in IDEs.

To trigger an internal error, it suffices to have 2 tokens in lint1's
input, after preprocessing: 'void __pure'.

diffstat:

 usr.bin/xlint/lint1/err.c |  12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diffs (36 lines):

diff -r f7d41d5d5b1b -r bd6606586a56 usr.bin/xlint/lint1/err.c
--- a/usr.bin/xlint/lint1/err.c Fri Mar 26 20:51:34 2021 +0000
+++ b/usr.bin/xlint/lint1/err.c Fri Mar 26 21:05:27 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: err.c,v 1.93 2021/03/26 20:31:07 rillig Exp $  */
+/*     $NetBSD: err.c,v 1.94 2021/03/26 21:05:27 rillig Exp $  */
 
 /*
  * Copyright (c) 1994, 1995 Jochen Pohl
@@ -37,7 +37,7 @@
 
 #include <sys/cdefs.h>
 #if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: err.c,v 1.93 2021/03/26 20:31:07 rillig Exp $");
+__RCSID("$NetBSD: err.c,v 1.94 2021/03/26 21:05:27 rillig Exp $");
 #endif
 
 #include <sys/types.h>
@@ -485,13 +485,13 @@
        va_list ap;
        const   char *fn;
 
+       fn = lbasename(curr_pos.p_file);
+       (void)fprintf(stderr, "lint: internal error in %s:%d near %s:%d: ",
+           file, line, fn, curr_pos.p_line);
        va_start(ap, msg);
-       fn = lbasename(curr_pos.p_file);
-       (void)fprintf(stderr, "%s(%d): lint error: %s, %d: ",
-           fn, curr_pos.p_line, file, line);
        (void)vfprintf(stderr, msg, ap);
+       va_end(ap);
        (void)fprintf(stderr, "\n");
-       va_end(ap);
        abort();
 }