Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/xen/xen fix tyop in KASSERT() condition which made ...



details:   https://anonhg.NetBSD.org/src/rev/cecd9242112e
branches:  trunk
changeset: 1011256:cecd9242112e
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Wed Jun 24 14:33:08 2020 +0000

description:
fix tyop in KASSERT() condition which made it an assignment rather than a check

the field indeed is supposed to be set to GRANT_INVALID_REF at this moment,
the grant must be already revoked by this time

pointed out by Taylor R Campbell

diffstat:

 sys/arch/xen/xen/if_xennet_xenbus.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 9466936c8279 -r cecd9242112e sys/arch/xen/xen/if_xennet_xenbus.c
--- a/sys/arch/xen/xen/if_xennet_xenbus.c       Wed Jun 24 14:28:10 2020 +0000
+++ b/sys/arch/xen/xen/if_xennet_xenbus.c       Wed Jun 24 14:33:08 2020 +0000
@@ -1,4 +1,4 @@
-/*      $NetBSD: if_xennet_xenbus.c,v 1.126 2020/05/14 13:25:40 jdolecek Exp $      */
+/*      $NetBSD: if_xennet_xenbus.c,v 1.127 2020/06/24 14:33:08 jdolecek Exp $      */
 
 /*
  * Copyright (c) 2006 Manuel Bouyer.
@@ -81,7 +81,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_xennet_xenbus.c,v 1.126 2020/05/14 13:25:40 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_xennet_xenbus.c,v 1.127 2020/06/24 14:33:08 jdolecek Exp $");
 
 #include "opt_xen.h"
 #include "opt_nfs_boot.h"
@@ -774,7 +774,7 @@
                KASSERT(req != NULL);
                KASSERT(req == &sc->sc_rxreqs[req->rxreq_id]);
                KASSERT(req->rxreq_m == NULL);
-               KASSERT(req->rxreq_gntref = GRANT_INVALID_REF);
+               KASSERT(req->rxreq_gntref == GRANT_INVALID_REF);
 
                MGETHDR(m, M_DONTWAIT, MT_DATA);
                if (__predict_false(m == NULL)) {



Home | Main Index | Thread Index | Old Index