Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci Send packets even if link state is not up



details:   https://anonhg.NetBSD.org/src/rev/d5343413c4f8
branches:  trunk
changeset: 1007893:d5343413c4f8
user:      yamaguchi <yamaguchi%NetBSD.org@localhost>
date:      Tue Mar 03 04:55:46 2020 +0000

description:
Send packets even if link state is not up

ixl(4) has not the limitation that it must not send packet when
link is down. And most of the other NIC drivers do not refer to it
when sending packets.

reviewed by knakahara@n.o, thanks.

diffstat:

 sys/dev/pci/if_ixl.c |  7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diffs (28 lines):

diff -r 847c087cedee -r d5343413c4f8 sys/dev/pci/if_ixl.c
--- a/sys/dev/pci/if_ixl.c      Tue Mar 03 04:34:45 2020 +0000
+++ b/sys/dev/pci/if_ixl.c      Tue Mar 03 04:55:46 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_ixl.c,v 1.59 2020/03/03 04:34:45 yamaguchi Exp $    */
+/*     $NetBSD: if_ixl.c,v 1.60 2020/03/03 04:55:46 yamaguchi Exp $    */
 
 /*
  * Copyright (c) 2013-2015, Intel Corporation
@@ -74,7 +74,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_ixl.c,v 1.59 2020/03/03 04:34:45 yamaguchi Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_ixl.c,v 1.60 2020/03/03 04:55:46 yamaguchi Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_net_mpsafe.h"
@@ -2733,8 +2733,7 @@
 
        KASSERT(mutex_owned(&txr->txr_lock));
 
-       if (ifp->if_link_state != LINK_STATE_UP
-           || !ISSET(ifp->if_flags, IFF_RUNNING)
+       if (!ISSET(ifp->if_flags, IFF_RUNNING)
            || (!is_transmit && ISSET(ifp->if_flags, IFF_OACTIVE))) {
                if (!is_transmit)
                        IFQ_PURGE(&ifp->if_snd);



Home | Main Index | Thread Index | Old Index