Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/conf sys/conf/lint.mk: fix order of command line options



details:   https://anonhg.NetBSD.org/src/rev/b2e8b077ea45
branches:  trunk
changeset: 983086:b2e8b077ea45
user:      rillig <rillig%NetBSD.org@localhost>
date:      Sun May 02 20:11:43 2021 +0000

description:
sys/conf/lint.mk: fix order of command line options

The option -o must come before the first filename.

Now it is possible to lint kern_exec.c at least.  The next failure is in
netbsd32_machdep.c:

        netbsd32_machdep.c(395): error: illegal bit-field size: 255 [36]

That line in netbsd32_process_read_fpregs reads:

        __CTASSERT(sizeof(*regs) == sizeof(struct save87));

This is probably a bug in lint.  The struct save87 contains 3 uint16_t,
followed by a union containing a uint64_t, followed by a packed struct
with size 10.  The combination of packed and padding is suspicious.

diffstat:

 sys/conf/lint.mk |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (18 lines):

diff -r 2c2fe36282fb -r b2e8b077ea45 sys/conf/lint.mk
--- a/sys/conf/lint.mk  Sun May 02 19:51:57 2021 +0000
+++ b/sys/conf/lint.mk  Sun May 02 20:11:43 2021 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: lint.mk,v 1.3 2021/05/02 19:51:57 rillig Exp $
+# $NetBSD: lint.mk,v 1.4 2021/05/02 20:11:43 rillig Exp $
 
 ##
 ## lint
@@ -9,7 +9,7 @@
 ALLSFILES?=    ${MD_SFILES} ${SFILES}
 LINTSTUBS?=    ${ALLSFILES:T:R:C/^.*$/LintStub_&.c/g}
 KERNLINTFLAGS?=        -bceghnxzFS
-NORMAL_LN?=    ${LINT} ${KERNLINTFLAGS} ${CPPFLAGS:M-[IDU]*} -i $< -o $@
+NORMAL_LN?=    ${LINT} ${KERNLINTFLAGS} ${CPPFLAGS:M-[IDU]*} -o $@ -i $<
 
 _lsrc=${CFILES} ${LINTSTUBS} ${MI_CFILES} ${MD_CFILES}
 LOBJS?= ${_lsrc:T:S/.c$/.ln/g} ${LIBKERNLN} ${SYSLIBCOMPATLN}



Home | Main Index | Thread Index | Old Index