Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/aarch64/aarch64 The bus_space(9) man page is not cl...



details:   https://anonhg.NetBSD.org/src/rev/ffd4db12155e
branches:  trunk
changeset: 979118:ffd4db12155e
user:      jmcneill <jmcneill%NetBSD.org@localhost>
date:      Mon Dec 14 11:16:33 2020 +0000

description:
The bus_space(9) man page is not clear whether barriers should enforce
ordering or completion. To be safe, use dsb here instead of dmb.

diffstat:

 sys/arch/aarch64/aarch64/bus_space.c |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (35 lines):

diff -r 5b5310c3bd05 -r ffd4db12155e sys/arch/aarch64/aarch64/bus_space.c
--- a/sys/arch/aarch64/aarch64/bus_space.c      Mon Dec 14 10:58:08 2020 +0000
+++ b/sys/arch/aarch64/aarch64/bus_space.c      Mon Dec 14 11:16:33 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: bus_space.c,v 1.11 2020/10/15 21:14:15 jmcneill Exp $ */
+/* $NetBSD: bus_space.c,v 1.12 2020/12/14 11:16:33 jmcneill Exp $ */
 
 /*
  * Copyright (c) 2017 Ryo Shimizu <ryo%nerv.org@localhost>
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(1, "$NetBSD: bus_space.c,v 1.11 2020/10/15 21:14:15 jmcneill Exp $");
+__KERNEL_RCSID(1, "$NetBSD: bus_space.c,v 1.12 2020/12/14 11:16:33 jmcneill Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -615,13 +615,13 @@
 
        switch (flags) {
        case BUS_SPACE_BARRIER_READ:
-               dmb(ishld);
+               dsb(ishld);
                break;
        case BUS_SPACE_BARRIER_WRITE:
-               dmb(ishst);
+               dsb(ishst);
                break;
        case BUS_SPACE_BARRIER_READ|BUS_SPACE_BARRIER_WRITE:
-               dmb(ish);
+               dsb(ish);
                break;
        }
 }



Home | Main Index | Thread Index | Old Index