Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/hppa/gsc Fix locking against myself.



details:   https://anonhg.NetBSD.org/src/rev/c786224885fd
branches:  trunk
changeset: 980407:c786224885fd
user:      isaki <isaki%NetBSD.org@localhost>
date:      Wed Feb 03 15:13:49 2021 +0000

description:
Fix locking against myself.
trigger_output will be called with sc_intr_lock held.
>From source code review, not tested.

diffstat:

 sys/arch/hppa/gsc/harmony.c |  6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diffs (27 lines):

diff -r 66b8a8778acb -r c786224885fd sys/arch/hppa/gsc/harmony.c
--- a/sys/arch/hppa/gsc/harmony.c       Wed Feb 03 15:08:17 2021 +0000
+++ b/sys/arch/hppa/gsc/harmony.c       Wed Feb 03 15:13:49 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: harmony.c,v 1.7 2019/06/08 08:02:37 isaki Exp $        */
+/*     $NetBSD: harmony.c,v 1.8 2021/02/03 15:13:49 isaki Exp $        */
 
 /*     $OpenBSD: harmony.c,v 1.23 2004/02/13 21:28:19 mickey Exp $     */
 
@@ -1004,8 +1004,6 @@
                return EINVAL;
        }
 
-       mutex_spin_enter(&sc->sc_intr_lock);
-
        c->c_intr = intr;
        c->c_intrarg = intrarg;
        c->c_blksz = blksize;
@@ -1020,8 +1018,6 @@
        harmony_start_cp(sc, 0);
        harmony_intr_enable(sc);
 
-       mutex_spin_exit(&sc->sc_intr_lock);
-
        return 0;
 }
 



Home | Main Index | Thread Index | Old Index