Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pckbport synaptics: Detect multiple fingers outside ...



details:   https://anonhg.NetBSD.org/src/rev/135f1605e82b
branches:  trunk
changeset: 970178:135f1605e82b
user:      nia <nia%NetBSD.org@localhost>
date:      Sat Mar 14 22:23:17 2020 +0000

description:
synaptics: Detect multiple fingers outside the gesture period

I suspect this code doesn't make any sense if we want two-finger scrolling

diffstat:

 sys/dev/pckbport/synaptics.c |  12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)

diffs (33 lines):

diff -r eb7f1580d6d6 -r 135f1605e82b sys/dev/pckbport/synaptics.c
--- a/sys/dev/pckbport/synaptics.c      Sat Mar 14 21:56:08 2020 +0000
+++ b/sys/dev/pckbport/synaptics.c      Sat Mar 14 22:23:17 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: synaptics.c,v 1.59 2020/03/14 21:56:08 nia Exp $       */
+/*     $NetBSD: synaptics.c,v 1.60 2020/03/14 22:23:17 nia Exp $       */
 
 /*
  * Copyright (c) 2005, Steve C. Woodford
@@ -48,7 +48,7 @@
 #include "opt_pms.h"
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: synaptics.c,v 1.59 2020/03/14 21:56:08 nia Exp $");
+__KERNEL_RCSID(0, "$NetBSD: synaptics.c,v 1.60 2020/03/14 22:23:17 nia Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1285,13 +1285,7 @@
                return (0);
        }
 
-       /*
-        * Detect 2 and 3 fingers if supported, but only if multiple
-        * fingers appear within the tap gesture time period.
-        */
-       if (sc->flags & SYN_FLAG_HAS_MULTI_FINGER &&
-           SYN_TIME(sc, sc->gesture_start_packet,
-           sp->sp_finger) < synaptics_gesture_length) {
+       if (sc->flags & SYN_FLAG_HAS_MULTI_FINGER) {
                switch (sp->sp_w) {
                case SYNAPTICS_WIDTH_TWO_FINGERS:
                        fingers = 2;



Home | Main Index | Thread Index | Old Index