Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/external/bsd/drm/dist/shared-core Delete dead-as-a-doorn...



details:   https://anonhg.NetBSD.org/src/rev/c39ae3c223c2
branches:  trunk
changeset: 965044:c39ae3c223c2
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Fri Aug 30 03:34:37 2019 +0000

description:
Delete dead-as-a-doornail-in-a-dead-horse branch.

If dev_priv is null here, you're hosed to begin with, so the apparent
null pointer dereference in this branch is moot; also this is the old
drm code that we should maybe just delete altogether...

Potential null pointer dereference reported by Dr Silvio Cesare of
InfoSect.

diffstat:

 sys/external/bsd/drm/dist/shared-core/radeon_cs.c |  5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diffs (15 lines):

diff -r 88f47bc53b7c -r c39ae3c223c2 sys/external/bsd/drm/dist/shared-core/radeon_cs.c
--- a/sys/external/bsd/drm/dist/shared-core/radeon_cs.c Fri Aug 30 00:36:53 2019 +0000
+++ b/sys/external/bsd/drm/dist/shared-core/radeon_cs.c Fri Aug 30 03:34:37 2019 +0000
@@ -148,11 +148,6 @@
        cs_id = 0;
        cs->cs_id = cs_id;
 
-       if (dev_priv == NULL) {
-               DRM_ERROR("called with no initialization\n");
-               DRM_SPINUNLOCK(&dev_priv->cs.cs_mutex);
-               return -EINVAL;
-       }
        if (!cs->num_chunks) {
                DRM_SPINUNLOCK(&dev_priv->cs.cs_mutex);
                return 0;



Home | Main Index | Thread Index | Old Index