Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/make make(1): remove void pointers from MakeBuildParent



details:   https://anonhg.NetBSD.org/src/rev/193b8f4b9786
branches:  trunk
changeset: 946362:193b8f4b9786
user:      rillig <rillig%NetBSD.org@localhost>
date:      Tue Nov 24 22:58:54 2020 +0000

description:
make(1): remove void pointers from MakeBuildParent

diffstat:

 usr.bin/make/make.c |  12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diffs (55 lines):

diff -r 672564650441 -r 193b8f4b9786 usr.bin/make/make.c
--- a/usr.bin/make/make.c       Tue Nov 24 22:55:24 2020 +0000
+++ b/usr.bin/make/make.c       Tue Nov 24 22:58:54 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: make.c,v 1.215 2020/11/24 22:55:24 rillig Exp $        */
+/*     $NetBSD: make.c,v 1.216 2020/11/24 22:58:54 rillig Exp $        */
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -102,7 +102,7 @@
 #include "job.h"
 
 /*     "@(#)make.c     8.1 (Berkeley) 6/6/93"  */
-MAKE_RCSID("$NetBSD: make.c,v 1.215 2020/11/24 22:55:24 rillig Exp $");
+MAKE_RCSID("$NetBSD: make.c,v 1.216 2020/11/24 22:58:54 rillig Exp $");
 
 /* Sequence # to detect recursion. */
 static unsigned int checked_seqno = 1;
@@ -112,7 +112,6 @@
  * It is added to by Make_Update and subtracted from by MakeStartJobs */
 static GNodeList *toBeMade;
 
-static int MakeBuildParent(void *, void *);
 
 void
 debug_printf(const char *fmt, ...)
@@ -576,6 +575,8 @@
     return FALSE;
 }
 
+static int MakeBuildParent(GNode *, GNodeListNode *);
+
 static void
 ScheduleOrderSuccessors(GNode *gn)
 {
@@ -853,7 +854,6 @@
     gn->flags |= DONE_ALLSRC;
 }
 
-/* XXX: Replace void pointers in parameters with proper types. */
 static int
 MakeBuildChild(GNode *cn, GNodeListNode *toBeMadeNext)
 {
@@ -898,10 +898,8 @@
 
 /* When a .ORDER LHS node completes, we do this on each RHS. */
 static int
-MakeBuildParent(void *v_pn, void *toBeMadeNext)
+MakeBuildParent(GNode *pn, GNodeListNode *toBeMadeNext)
 {
-    GNode *pn = v_pn;
-
     if (pn->made != DEFERRED)
        return 0;
 



Home | Main Index | Thread Index | Old Index