Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/fdt sfb_addr should be uint64_t, not bus_addr_t. Oth...



details:   https://anonhg.NetBSD.org/src/rev/1b44a6b8096e
branches:  trunk
changeset: 945120:1b44a6b8096e
user:      rin <rin%NetBSD.org@localhost>
date:      Wed Oct 21 11:02:31 2020 +0000

description:
sfb_addr should be uint64_t, not bus_addr_t. Otherwise, its value
cannot be obtained via prop_dictionary_get_uint64() for most ILP32
architectures where bus_addr_t is 32-bit width.

diffstat:

 sys/dev/fdt/simplefb.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r 994284214695 -r 1b44a6b8096e sys/dev/fdt/simplefb.c
--- a/sys/dev/fdt/simplefb.c    Wed Oct 21 08:20:13 2020 +0000
+++ b/sys/dev/fdt/simplefb.c    Wed Oct 21 11:02:31 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: simplefb.c,v 1.10 2020/10/20 23:03:30 jmcneill Exp $ */
+/* $NetBSD: simplefb.c,v 1.11 2020/10/21 11:02:31 rin Exp $ */
 
 /*-
  * Copyright (c) 2017 Jared McNeill <jmcneill%invisible.ca@localhost>
@@ -29,7 +29,7 @@
 #include "opt_wsdisplay_compat.h"
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: simplefb.c,v 1.10 2020/10/20 23:03:30 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: simplefb.c,v 1.11 2020/10/21 11:02:31 rin Exp $");
 
 #include <sys/param.h>
 #include <sys/bus.h>
@@ -132,7 +132,8 @@
        uint32_t width, height, stride;
        uint16_t depth;
        const char *format;
-       bus_addr_t addr, sfb_addr;
+       uint64_t sfb_addr;
+       bus_addr_t addr;
        bus_size_t size;
 
        if (fdtbus_get_reg(phandle, 0, &addr, &size) != 0) {



Home | Main Index | Thread Index | Old Index