Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/make/unit-tests make(1): fix wrong comments in test ...



details:   https://anonhg.NetBSD.org/src/rev/17667c300e39
branches:  trunk
changeset: 943414:17667c300e39
user:      rillig <rillig%NetBSD.org@localhost>
date:      Wed Sep 02 22:58:59 2020 +0000

description:
make(1): fix wrong comments in test for the .for loop

These comments were my original assumptions, which I wrote before
running the test and before looking at the implementation.

diffstat:

 usr.bin/make/unit-tests/directive-for.mk |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (35 lines):

diff -r a099de09a1eb -r 17667c300e39 usr.bin/make/unit-tests/directive-for.mk
--- a/usr.bin/make/unit-tests/directive-for.mk  Wed Sep 02 19:04:05 2020 +0000
+++ b/usr.bin/make/unit-tests/directive-for.mk  Wed Sep 02 22:58:59 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: directive-for.mk,v 1.1 2020/09/02 05:33:57 rillig Exp $
+# $NetBSD: directive-for.mk,v 1.2 2020/09/02 22:58:59 rillig Exp $
 #
 # Tests for the .for directive.
 
@@ -51,10 +51,10 @@
 .for var var2 in 1 2 3 4
 .endfor
 .if ${var} != "value before"
-.  warning var must be undefined.
+.  warning After the .for loop, var must still have its original value.
 .endif
 .if ${var2} != "value before"
-.  warning var2 must be undefined.
+.  warning After the .for loop, var2 must still have its original value.
 .endif
 
 # Everything from the paragraph above also applies if the loop body is
@@ -66,10 +66,10 @@
 .for var var2 in ${:U}
 .endfor
 .if ${var} != "value before"
-.  warning var must be undefined.
+.  warning After the .for loop, var must still have its original value.
 .endif
 .if ${var2} != "value before"
-.  warning var2 must be undefined.
+.  warning After the .for loop, var2 must still have its original value.
 .endif
 
 # Until 2008-12-21, the values of the iteration variables were simply



Home | Main Index | Thread Index | Old Index