[src/trunk]: src/sys/dev/usb Fix gross use-after-free. Found by a custom quer...

[maxv <maxv%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/8b61b72bd601
branches:  trunk
changeset: 466134:8b61b72bd601
user:      maxv <maxv%NetBSD.org@localhost>
date:      Fri Dec 13 14:10:32 2019 +0000

description:
Fix gross use-after-free. Found by a custom query on LGTM.

diffstat:

 sys/dev/usb/if_urtwn.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r 342d8abc5709 -r 8b61b72bd601 sys/dev/usb/if_urtwn.c
--- a/sys/dev/usb/if_urtwn.c    Fri Dec 13 12:05:11 2019 +0000
+++ b/sys/dev/usb/if_urtwn.c    Fri Dec 13 14:10:32 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_urtwn.c,v 1.77 2019/12/01 21:02:09 mlelstv Exp $    */
+/*     $NetBSD: if_urtwn.c,v 1.78 2019/12/13 14:10:32 maxv Exp $       */
 /*     $OpenBSD: if_urtwn.c,v 1.42 2015/02/10 23:25:46 mpi Exp $       */
 
 /*-
@@ -25,7 +25,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_urtwn.c,v 1.77 2019/12/01 21:02:09 mlelstv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_urtwn.c,v 1.78 2019/12/13 14:10:32 maxv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -868,7 +868,6 @@
                }
 
                if (urtwn_tx_beacon(sc, m, ic->ic_bss) != 0) {
-                       m_freem(m);
                        aprint_error_dev(sc->sc_dev, "could not send beacon");
                }