Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci Remove unnecessary checks of IFF_ALLMULTI



details:   https://anonhg.NetBSD.org/src/rev/9ebcf9f7186b
branches:  trunk
changeset: 451290:9ebcf9f7186b
user:      ozaki-r <ozaki-r%NetBSD.org@localhost>
date:      Tue May 14 09:43:55 2019 +0000

description:
Remove unnecessary checks of IFF_ALLMULTI

IFF_ALLMULTI is changed by only driver itself, so we don't need to check its
change on ec_ifflags_cb.

This is part of PR kern/54189. NFCI.

diffstat:

 sys/dev/pci/if_wm.c       |  6 +++---
 sys/dev/pci/ixgbe/ixgbe.c |  4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diffs (45 lines):

diff -r 5192e225bc23 -r 9ebcf9f7186b sys/dev/pci/if_wm.c
--- a/sys/dev/pci/if_wm.c       Tue May 14 07:45:03 2019 +0000
+++ b/sys/dev/pci/if_wm.c       Tue May 14 09:43:55 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_wm.c,v 1.634 2019/04/24 11:18:20 msaitoh Exp $      */
+/*     $NetBSD: if_wm.c,v 1.635 2019/05/14 09:43:55 ozaki-r Exp $      */
 
 /*
  * Copyright (c) 2001, 2002, 2003, 2004 Wasabi Systems, Inc.
@@ -82,7 +82,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.634 2019/04/24 11:18:20 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.635 2019/05/14 09:43:55 ozaki-r Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_net_mpsafe.h"
@@ -3319,7 +3319,7 @@
        }
 
        /* iff related updates */
-       if ((iffchange & (IFF_PROMISC | IFF_ALLMULTI)) != 0)
+       if ((iffchange & IFF_PROMISC) != 0)
                wm_set_filter(sc);
 
        wm_set_vlan(sc);
diff -r 5192e225bc23 -r 9ebcf9f7186b sys/dev/pci/ixgbe/ixgbe.c
--- a/sys/dev/pci/ixgbe/ixgbe.c Tue May 14 07:45:03 2019 +0000
+++ b/sys/dev/pci/ixgbe/ixgbe.c Tue May 14 09:43:55 2019 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: ixgbe.c,v 1.181 2019/05/13 05:04:17 msaitoh Exp $ */
+/* $NetBSD: ixgbe.c,v 1.182 2019/05/14 09:43:55 ozaki-r Exp $ */
 
 /******************************************************************************
 
@@ -6163,7 +6163,7 @@
 
        if ((change & ~(IFF_CANTCHANGE | IFF_DEBUG)) != 0)
                rc = ENETRESET;
-       else if ((change & (IFF_PROMISC | IFF_ALLMULTI)) != 0)
+       else if ((change & IFF_PROMISC) != 0)
                ixgbe_set_promisc(adapter);
 
        /* Set up VLAN support and filter */



Home | Main Index | Thread Index | Old Index