Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic bio(4) drivers: remove noop fallthrough-to-defaul...



details:   https://anonhg.NetBSD.org/src/rev/08d087a0df86
branches:  trunk
changeset: 451153:08d087a0df86
user:      cnst <cnst%NetBSD.org@localhost>
date:      Wed May 08 05:40:51 2019 +0000

description:
bio(4) drivers: remove noop fallthrough-to-default bio(4) cmd cases

* Makes it easier to do code/feature analysis by not having
  extra noop code/symbols spattered around.

* Only an issue in cac(4) and ciss(4); other drivers don't do this.

* No binary changes.

diffstat:

 sys/dev/ic/cac.c  |  7 ++-----
 sys/dev/ic/ciss.c |  6 ++----
 2 files changed, 4 insertions(+), 9 deletions(-)

diffs (55 lines):

diff -r 4f490f5f6e48 -r 08d087a0df86 sys/dev/ic/cac.c
--- a/sys/dev/ic/cac.c  Wed May 08 04:34:33 2019 +0000
+++ b/sys/dev/ic/cac.c  Wed May 08 05:40:51 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: cac.c,v 1.59 2018/09/03 16:29:31 riastradh Exp $       */
+/*     $NetBSD: cac.c,v 1.60 2019/05/08 05:40:51 cnst Exp $    */
 
 /*-
  * Copyright (c) 2000, 2006, 2007 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cac.c,v 1.59 2018/09/03 16:29:31 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cac.c,v 1.60 2019/05/08 05:40:51 cnst Exp $");
 
 #if defined(_KERNEL_OPT)
 #include "bio.h"
@@ -642,9 +642,6 @@
                /* No disk information yet */
                break;
 
-       case BIOCBLINK:
-       case BIOCALARM:
-       case BIOCSETSTATE:
        default:
                error = EINVAL;
        }
diff -r 4f490f5f6e48 -r 08d087a0df86 sys/dev/ic/ciss.c
--- a/sys/dev/ic/ciss.c Wed May 08 04:34:33 2019 +0000
+++ b/sys/dev/ic/ciss.c Wed May 08 05:40:51 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ciss.c,v 1.39 2018/09/03 16:29:31 riastradh Exp $      */
+/*     $NetBSD: ciss.c,v 1.40 2019/05/08 05:40:51 cnst Exp $   */
 /*     $OpenBSD: ciss.c,v 1.68 2013/05/30 16:15:02 deraadt Exp $       */
 
 /*
@@ -19,7 +19,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ciss.c,v 1.39 2018/09/03 16:29:31 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ciss.c,v 1.40 2019/05/08 05:40:51 cnst Exp $");
 
 #include "bio.h"
 
@@ -1390,8 +1390,6 @@
                }
                break;
 
-       case BIOCALARM:
-       case BIOCSETSTATE:
        default:
                error = EINVAL;
        }



Home | Main Index | Thread Index | Old Index