Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/x86 Add five errata for AMD Family 17h (Ryzen etc), ...



details:   https://anonhg.NetBSD.org/src/rev/db0f9356b42a
branches:  trunk
changeset: 363690:db0f9356b42a
user:      maxv <maxv%NetBSD.org@localhost>
date:      Tue Aug 07 10:50:12 2018 +0000

description:
Add five errata for AMD Family 17h (Ryzen etc), tested by Patrick Welche,
thanks. Also add two errata for Family 16h, not yet tested, so not yet
enabled.

diffstat:

 sys/arch/x86/include/specialreg.h |  13 +++++-
 sys/arch/x86/x86/errata.c         |  88 ++++++++++++++++++++++++++++++++++++--
 2 files changed, 95 insertions(+), 6 deletions(-)

diffs (173 lines):

diff -r c750eeeca5f6 -r db0f9356b42a sys/arch/x86/include/specialreg.h
--- a/sys/arch/x86/include/specialreg.h Tue Aug 07 09:01:52 2018 +0000
+++ b/sys/arch/x86/include/specialreg.h Tue Aug 07 10:50:12 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: specialreg.h,v 1.128 2018/07/13 09:37:32 maxv Exp $    */
+/*     $NetBSD: specialreg.h,v 1.129 2018/08/07 10:50:12 maxv Exp $    */
 
 /*-
  * Copyright (c) 1991 The Regents of the University of California.
@@ -857,6 +857,9 @@
 #define        NB_CFG_INITAPICCPUIDLO  (1ULL << 54)
 
 #define MSR_LS_CFG     0xc0011020
+#define        LS_CFG_ERRATA_1033      __BIT(4)
+#define        LS_CFG_ERRATA_793       __BIT(15)
+#define        LS_CFG_ERRATA_1095      __BIT(57)
 #define        LS_CFG_DIS_LS2_SQUISH   0x02000000
 #define        LS_CFG_DIS_SSB_F15H     0x0040000000000000ULL
 #define        LS_CFG_DIS_SSB_F16H     0x0000000200000000ULL
@@ -865,6 +868,7 @@
 #define MSR_IC_CFG     0xc0011021
 #define        IC_CFG_DIS_SEQ_PREFETCH 0x00000800
 #define        IC_CFG_DIS_IND          0x00004000
+#define        IC_CFG_ERRATA_776       __BIT(26)
 
 #define MSR_DC_CFG     0xc0011022
 #define        DC_CFG_DIS_CNV_WC_SSO   0x00000008
@@ -879,8 +883,15 @@
 #define        BU_CFG_WBPFSMCCHKDIS    0x0000200000000000ULL
 #define        BU_CFG_WBENHWSBDIS      0x0001000000000000ULL
 
+#define MSR_FP_CFG     0xc0011028
+#define        FP_CFG_ERRATA_1049      __BIT(4)
+
 #define MSR_DE_CFG     0xc0011029
 #define        DE_CFG_ERRATA_721       0x00000001
+#define        DE_CFG_ERRATA_1021      __BIT(13)
+
+#define MSR_LS_CFG2    0xc001102d
+#define        LS_CFG2_ERRATA_1091     __BIT(34)
 
 /* AMD Family10h MSRs */
 #define MSR_OSVW_ID_LENGTH             0xc0010140
diff -r c750eeeca5f6 -r db0f9356b42a sys/arch/x86/x86/errata.c
--- a/sys/arch/x86/x86/errata.c Tue Aug 07 09:01:52 2018 +0000
+++ b/sys/arch/x86/x86/errata.c Tue Aug 07 10:50:12 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: errata.c,v 1.23 2016/01/05 10:20:22 hannken Exp $      */
+/*     $NetBSD: errata.c,v 1.24 2018/08/07 10:50:12 maxv Exp $ */
 
 /*-
  * Copyright (c) 2007 The NetBSD Foundation, Inc.
@@ -45,7 +45,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: errata.c,v 1.23 2016/01/05 10:20:22 hannken Exp $");
+__KERNEL_RCSID(0, "$NetBSD: errata.c,v 1.24 2018/08/07 10:50:12 maxv Exp $");
 
 #include <sys/types.h>
 #include <sys/systm.h>
@@ -70,8 +70,8 @@
        BH_E4, CH_CG, CH_D0, DH_CG, DH_D0, DH_E3, DH_E6, JH_E1,
        JH_E6, SH_B0, SH_B3, SH_C0, SH_CG, SH_D0, SH_E4, SH_E5,
        DR_BA, DR_B2, DR_B3, RB_C2, RB_C3, BL_C2, BL_C3, DA_C2,
-       DA_C3, HY_D0, HY_D1, HY_D1_G34R1,  PH_E0, LN_B0,
-       OINK
+       DA_C3, HY_D0, HY_D1, HY_D1_G34R1,  PH_E0, LN_B0, KB_A1,
+       ML_A1, ZP_B1, ZP_B2, PiR_B2, OINK
 } cpurev_t;
 
 static const u_int cpurevs[] = {
@@ -89,7 +89,9 @@
        RB_C2, 0x0100f42, RB_C3, 0x0100f43, BL_C2, 0x0100f52,
        BL_C3, 0x0100f53, DA_C2, 0x0100f62, DA_C3, 0x0100f63,
        HY_D0, 0x0100f80, HY_D1, 0x0100f81, HY_D1_G34R1, 0x0100f91,
-       PH_E0, 0x0100fa0, LN_B0, 0x0300f10,
+       PH_E0, 0x0100fa0, LN_B0, 0x0300f10, KB_A1, 0x0700F01,
+       ML_A1, 0x0730F01, ZP_B1, 0x0800F11, ZP_B2, 0x0800F12,
+       PiR_B2, 0x0800F82,
        OINK
 };
 
@@ -142,6 +144,26 @@
        DA_C3, HY_D0, HY_D1, HY_D1_G34R1,  PH_E0, LN_B0, OINK
 };
 
+#ifdef notyet_f16h
+static const uint8_t x86_errata_set12[] = {
+       KB_A1, OINK
+};
+#endif
+
+static const uint8_t x86_errata_set13[] = {
+       ZP_B1, ZP_B2, PiR_B2, OINK
+};
+
+static const uint8_t x86_errata_set14[] = {
+       ZP_B1, OINK
+};
+
+#ifdef notyet_f16h
+static const uint8_t x86_errata_set15[] = {
+       KB_A1, ML_A1, OINK
+};
+#endif
+
 static bool x86_errata_setmsr(struct cpu_info *, errata_t *);
 static bool x86_errata_testmsr(struct cpu_info *, errata_t *);
 
@@ -285,6 +307,62 @@
                721, FALSE, MSR_DE_CFG, x86_errata_set11,
                x86_errata_setmsr, DE_CFG_ERRATA_721
        },
+#ifdef notyet_f16h     /* TODO: needs to be tested */
+       /*
+        * 776: Incorrect Processor Branch Prediction for Two Consecutive
+        * Linear Pages
+        */
+       {
+               776, FALSE, MSR_IC_CFG, x86_errata_set12,
+               x86_errata_setmsr, IC_CFG_ERRATA_776
+       },
+       /*
+        * 793: Specific Combination of Writes to Write Combined Memory
+        * Types and Locked Instructions May Cause Core Hang
+        */
+       {
+               793, FALSE, MSR_LS_CFG, x86_errata_set15,
+               x86_errata_setmsr, LS_CFG_ERRATA_793
+       },
+#endif
+       /*
+        * 1021: Load Operation May Receive Stale Data From Older Store
+        * Operation
+        */
+       {
+               1021, FALSE, MSR_DE_CFG, x86_errata_set13,
+               x86_errata_setmsr, DE_CFG_ERRATA_1021
+       },
+       /*
+        * 1033: A Lock Operation May Cause the System to Hang
+        */
+       {
+               1033, FALSE, MSR_LS_CFG, x86_errata_set14,
+               x86_errata_setmsr, LS_CFG_ERRATA_1033
+       },
+       /*
+        * 1049: FCMOV Instruction May Not Execute Correctly
+        */
+       {
+               1049, FALSE, MSR_FP_CFG, x86_errata_set13,
+               x86_errata_setmsr, FP_CFG_ERRATA_1049
+       },
+       /*
+        * 1091: Address Boundary Crossing Load Operation May Receive
+        * Stale Data
+        */
+       {
+               1091, FALSE, MSR_LS_CFG2, x86_errata_set13,
+               x86_errata_setmsr, LS_CFG2_ERRATA_1091
+       },
+       /*
+        * 1095: Potential Violation of Read Ordering In Lock Operation
+        * In SMT (Simultaneous Multithreading) Mode
+        */
+       {
+               1095, FALSE, MSR_LS_CFG, x86_errata_set13,
+               x86_errata_setmsr, LS_CFG_ERRATA_1095
+       },
 };
 
 static bool 



Home | Main Index | Thread Index | Old Index