Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/x86/x86 Operation pmap_tlb_processpacket() uses x86...



details:   https://anonhg.NetBSD.org/src/rev/bee6f1296785
branches:  trunk
changeset: 339485:bee6f1296785
user:      hannken <hannken%NetBSD.org@localhost>
date:      Fri Jul 24 15:20:37 2015 +0000

description:
Operation pmap_tlb_processpacket() uses x86_ipi(.., LAPIC_DEST_ALLEXCL, ...)
when cpuset "target" equals "kcpuset_running".  During boot, while some CPUs
are not running yet, this will result in more IPI interrupts than expected
and "pmap_tlb_pendcount" related KASSERTs fire.

Compare the cpuset "target" against "kcpuset_attached", as this set represents
the CPUs LAPIC_DEST_ALLEXCL will notify.

Should fix PR port-amd64/47437

diffstat:

 sys/arch/x86/x86/pmap_tlb.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r f101c83f4926 -r bee6f1296785 sys/arch/x86/x86/pmap_tlb.c
--- a/sys/arch/x86/x86/pmap_tlb.c       Fri Jul 24 14:11:11 2015 +0000
+++ b/sys/arch/x86/x86/pmap_tlb.c       Fri Jul 24 15:20:37 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pmap_tlb.c,v 1.6 2012/04/21 22:22:48 rmind Exp $       */
+/*     $NetBSD: pmap_tlb.c,v 1.7 2015/07/24 15:20:37 hannken Exp $     */
 
 /*-
  * Copyright (c) 2008-2012 The NetBSD Foundation, Inc.
@@ -40,7 +40,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pmap_tlb.c,v 1.6 2012/04/21 22:22:48 rmind Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pmap_tlb.c,v 1.7 2015/07/24 15:20:37 hannken Exp $");
 
 #include <sys/param.h>
 #include <sys/kernel.h>
@@ -297,7 +297,7 @@
 {
        int err = 0;
 
-       if (!kcpuset_match(target, kcpuset_running)) {
+       if (!kcpuset_match(target, kcpuset_attached)) {
                const struct cpu_info * const self = curcpu();
                CPU_INFO_ITERATOR cii;
                struct cpu_info *lci;



Home | Main Index | Thread Index | Old Index