Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/scsipi Pass a correct residual size to wdcbit_bucket...



details:   https://anonhg.NetBSD.org/src/rev/f377381b5460
branches:  trunk
changeset: 344288:f377381b5460
user:      tsutsui <tsutsui%NetBSD.org@localhost>
date:      Sun Mar 20 10:29:12 2016 +0000

description:
Pass a correct residual size to wdcbit_bucket() that drains extra bytes.

Seems broken (but almost harmless?) since rev 1.101 committed ~10 years ago:
 http://mail-index.netbsd.org/source-changes/2006/09/07/0043.html

diffstat:

 sys/dev/scsipi/atapi_wdc.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r f9ef4e405ec3 -r f377381b5460 sys/dev/scsipi/atapi_wdc.c
--- a/sys/dev/scsipi/atapi_wdc.c        Sun Mar 20 09:47:58 2016 +0000
+++ b/sys/dev/scsipi/atapi_wdc.c        Sun Mar 20 10:29:12 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: atapi_wdc.c,v 1.120 2016/03/20 09:47:58 tsutsui Exp $  */
+/*     $NetBSD: atapi_wdc.c,v 1.121 2016/03/20 10:29:12 tsutsui Exp $  */
 
 /*
  * Copyright (c) 1998, 2001 Manuel Bouyer.
@@ -25,7 +25,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: atapi_wdc.c,v 1.120 2016/03/20 09:47:58 tsutsui Exp $");
+__KERNEL_RCSID(0, "$NetBSD: atapi_wdc.c,v 1.121 2016/03/20 10:29:12 tsutsui Exp $");
 
 #ifndef ATADEBUG
 #define ATADEBUG
@@ -930,7 +930,7 @@
        end_piobm_datain:
 #endif
                if (xfer->c_lenoff > 0)
-                       wdcbit_bucket(chp, len - xfer->c_bcount);
+                       wdcbit_bucket(chp, xfer->c_lenoff);
 
                xfer->c_skip += len;
                xfer->c_bcount -= len;



Home | Main Index | Thread Index | Old Index