Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/compat/common Hmmm, if we omit if_43.c from the SRCS lis...



details:   https://anonhg.NetBSD.org/src/rev/4222cc3c96db
branches:  trunk
changeset: 348711:4222cc3c96db
user:      pgoyette <pgoyette%NetBSD.org@localhost>
date:      Thu Nov 03 11:32:15 2016 +0000

description:
Hmmm, if we omit if_43.c from the SRCS list, then we break the i386
build for one of the XEN kernels.

Adding it back to the list.  At least the build will be successful.

XXX This is probably not the end of this saga, as we still have the
XXX redefined-symbol issue when loading the compat module on amd64.
XXX But for now, a working build for the vast majority of users
XXX (including our automated test suites) is more important than a
XXX successfully-loadable compat module.

diffstat:

 sys/compat/common/Makefile.sysio |  13 ++-----------
 1 files changed, 2 insertions(+), 11 deletions(-)

diffs (25 lines):

diff -r 8e85afe96983 -r 4222cc3c96db sys/compat/common/Makefile.sysio
--- a/sys/compat/common/Makefile.sysio  Thu Nov 03 11:20:45 2016 +0000
+++ b/sys/compat/common/Makefile.sysio  Thu Nov 03 11:32:15 2016 +0000
@@ -1,19 +1,10 @@
-#      $NetBSD: Makefile.sysio,v 1.4 2016/11/03 06:54:08 pgoyette Exp $
+#      $NetBSD: Makefile.sysio,v 1.5 2016/11/03 11:32:15 pgoyette Exp $
 
 # Sources for syscall and ioctl compatibility across the versions.
 
 # Compatibility code for 4.3BSD
 SRCS+= kern_exit_43.c kern_info_43.c kern_resource_43.c kern_sig_43.c \
-       tty_43.c uipc_syscalls_43.c vfs_syscalls_43.c vm_43.c
-
-# if_43.o gets included from libcompat automatically, due to two calls
-# to compat_cvtcmd() in if.c.  Ideally, if.c would be modified to have
-# a pointer to a no-op compat_cvtcmd() and that pointer would get
-# replaced by compat_mnodcmd(MODULE_CMD_INIT, ...) code.  But for now,
-# just don't include it in the compat module at all.
-#
-#SRCS+=        if_43.c
-#
+       tty_43.c uipc_syscalls_43.c vfs_syscalls_43.c vm_43.c if_43.c
 
 # Compatibility code for NetBSD 0.9
 SRCS+= kern_info_09.c



Home | Main Index | Thread Index | Old Index