Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/i386/i386 Use offsets to access the TPR, and not la...



details:   https://anonhg.NetBSD.org/src/rev/b077e2db7226
branches:  trunk
changeset: 348375:b077e2db7226
user:      maxv <maxv%NetBSD.org@localhost>
date:      Sun Oct 16 10:38:49 2016 +0000

description:
Use offsets to access the TPR, and not lapic_tpr.

For the record: I'm not sure exactly why it was originally done this way,
and the cvs logs are not quite enlightening. It might have been a way to
speed up the asm access, but it would sound a little bizarre since there
are many more legitimate reasons to do it on the EOI register instead.

diffstat:

 sys/arch/i386/i386/vector.S |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (33 lines):

diff -r c09d5e6228b6 -r b077e2db7226 sys/arch/i386/i386/vector.S
--- a/sys/arch/i386/i386/vector.S       Sun Oct 16 10:24:58 2016 +0000
+++ b/sys/arch/i386/i386/vector.S       Sun Oct 16 10:38:49 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: vector.S,v 1.65 2016/08/07 10:17:32 maxv Exp $ */
+/*     $NetBSD: vector.S,v 1.66 2016/10/16 10:38:49 maxv Exp $ */
 
 /*
  * Copyright 2002 (c) Wasabi Systems, Inc.
@@ -65,7 +65,7 @@
  */
 
 #include <machine/asm.h>
-__KERNEL_RCSID(0, "$NetBSD: vector.S,v 1.65 2016/08/07 10:17:32 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: vector.S,v 1.66 2016/10/16 10:38:49 maxv Exp $");
 
 #include "opt_ddb.h"
 #include "opt_multiprocessor.h"
@@ -201,12 +201,12 @@
        movzwl  (%eax),%eax
        GET_TSS
        pushl   %eax
-       movl    $0xff,_C_LABEL(lapic_tpr)
+       movl    $0xff,_C_LABEL(local_apic)+LAPIC_TPRI
        movl    $0,_C_LABEL(local_apic)+LAPIC_EOI
        sti
        call    _C_LABEL(ddb_ipi_tss)
        addl    $4,%esp
-       movl    $0,_C_LABEL(lapic_tpr)
+       movl    $0,_C_LABEL(local_apic)+LAPIC_TPRI
        iret
        jmp     1b
 IDTVEC_END(intrddbipi)



Home | Main Index | Thread Index | Old Index