Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/external/bsd/wpa/dist/src/drivers Create global init to hand...



details:   https://anonhg.NetBSD.org/src/rev/4d086fa158b8
branches:  trunk
changeset: 342938:4d086fa158b8
user:      roy <roy%NetBSD.org@localhost>
date:      Thu Jan 14 21:19:41 2016 +0000

description:
Create global init to handle socket calls and route messages.
Register each interface inside the global driver so that
routing messages can find the interface based on rtm_ifindex.

diffstat:

 external/bsd/wpa/dist/src/drivers/driver_bsd.c |  216 ++++++++++++++----------
 1 files changed, 129 insertions(+), 87 deletions(-)

diffs (truncated from 503 to 300 lines):

diff -r 6ff3af48141d -r 4d086fa158b8 external/bsd/wpa/dist/src/drivers/driver_bsd.c
--- a/external/bsd/wpa/dist/src/drivers/driver_bsd.c    Thu Jan 14 21:15:51 2016 +0000
+++ b/external/bsd/wpa/dist/src/drivers/driver_bsd.c    Thu Jan 14 21:19:41 2016 +0000
@@ -47,12 +47,20 @@
 
 #include "l2_packet/l2_packet.h"
 
+struct bsd_driver_global {
+       int             sock;                   /* socket for 802.11 ioctls */
+       int             route;                  /* routing socket for events */
+       char            *event_buf;
+       size_t          event_buf_len;
+       struct dl_list  ifaces;                 /* list of interfaces */
+};
+
 struct bsd_driver_data {
+       struct dl_list  list;
+       struct bsd_driver_global *global;
        struct hostapd_data *hapd;      /* back pointer */
 
-       int     sock;                   /* open socket for 802.11 ioctls */
        struct l2_packet_data *sock_xmit;/* raw packet xmit socket */
-       int     route;                  /* routing socket for events */
        char    ifname[IFNAMSIZ+1];     /* interface name */
        int     flags;
        unsigned int ifindex;           /* interface index */
@@ -63,12 +71,23 @@
        int     prev_privacy;   /* privacy state to restore on deinit */
        int     prev_wpa;       /* wpa state to restore on deinit */
        enum ieee80211_opmode opmode;   /* operation mode */
-       char    *event_buf;
-       size_t  event_buf_len;
 };
 
 /* Generic functions for hostapd and wpa_supplicant */
 
+static struct bsd_driver_data *
+bsd_get_drvindex(void *priv, unsigned int ifindex)
+{
+       struct bsd_driver_global *global = priv;
+       struct bsd_driver_data *drv;
+
+       dl_list_for_each(drv, &global->ifaces, struct bsd_driver_data, list) {
+               if (drv->ifindex == ifindex)
+                       return drv;
+       }
+       return NULL;
+}
+
 static int
 bsd_set80211(void *priv, int op, int val, const void *arg, int arg_len)
 {
@@ -82,7 +101,7 @@
        ireq.i_data = (void *) arg;
        ireq.i_len = arg_len;
 
-       if (ioctl(drv->sock, SIOCS80211, &ireq) < 0) {
+       if (ioctl(drv->global->sock, SIOCS80211, &ireq) < 0) {
                wpa_printf(MSG_ERROR, "ioctl[SIOCS80211, op=%u, val=%u, "
                           "arg_len=%u]: %s", op, val, arg_len,
                           strerror(errno));
@@ -103,7 +122,7 @@
        ireq->i_len = arg_len;
        ireq->i_data = arg;
 
-       if (ioctl(drv->sock, SIOCG80211, ireq) < 0) {
+       if (ioctl(drv->global->sock, SIOCG80211, ireq) < 0) {
                wpa_printf(MSG_ERROR, "ioctl[SIOCS80211, op=%u, "
                           "arg_len=%u]: %s", op, arg_len, strerror(errno));
                return -1;
@@ -144,7 +163,7 @@
        os_memset(&ifr, 0, sizeof(ifr));
        os_strlcpy(ifr.ifr_name, drv->ifname, sizeof(ifr.ifr_name));
        ifr.ifr_data = (void *)&nwid;
-       if (ioctl(drv->sock, SIOCG80211NWID, &ifr) < 0 ||
+       if (ioctl(drv->global->sock, SIOCG80211NWID, &ifr) < 0 ||
            nwid.i_len > IEEE80211_NWID_LEN)
                return -1;
        os_memcpy(ssid, nwid.i_nwid, nwid.i_len);
@@ -167,7 +186,7 @@
        os_memset(&ifr, 0, sizeof(ifr));
        os_strlcpy(ifr.ifr_name, drv->ifname, sizeof(ifr.ifr_name));
        ifr.ifr_data = (void *)&nwid;
-       return ioctl(drv->sock, SIOCS80211NWID, &ifr);
+       return ioctl(drv->global->sock, SIOCS80211NWID, &ifr);
 #else
        return set80211var(drv, IEEE80211_IOC_SSID, ssid, ssid_len);
 #endif
@@ -182,7 +201,7 @@
        os_memset(&ifmr, 0, sizeof(ifmr));
        os_strlcpy(ifmr.ifm_name, drv->ifname, sizeof(ifmr.ifm_name));
 
-       if (ioctl(drv->sock, SIOCGIFMEDIA, &ifmr) < 0) {
+       if (ioctl(drv->global->sock, SIOCGIFMEDIA, &ifmr) < 0) {
                wpa_printf(MSG_ERROR, "%s: SIOCGIFMEDIA %s", __func__,
                           strerror(errno));
                return -1;
@@ -201,7 +220,7 @@
        os_strlcpy(ifr.ifr_name, drv->ifname, sizeof(ifr.ifr_name));
        ifr.ifr_media = media;
 
-       if (ioctl(drv->sock, SIOCSIFMEDIA, &ifr) < 0) {
+       if (ioctl(drv->global->sock, SIOCSIFMEDIA, &ifr) < 0) {
                wpa_printf(MSG_ERROR, "%s: SIOCSIFMEDIA %s", __func__,
                           strerror(errno));
                return -1;
@@ -264,7 +283,7 @@
        os_memset(&ifr, 0, sizeof(ifr));
        os_strlcpy(ifr.ifr_name, drv->ifname, sizeof(ifr.ifr_name));
 
-       if (ioctl(drv->sock, SIOCGIFFLAGS, &ifr) < 0) {
+       if (ioctl(drv->global->sock, SIOCGIFFLAGS, &ifr) < 0) {
                wpa_printf(MSG_ERROR, "ioctl[SIOCGIFFLAGS]: %s",
                           strerror(errno));
                return -1;
@@ -280,7 +299,7 @@
                ifr.ifr_flags &= ~IFF_UP;
        }
 
-       if (ioctl(drv->sock, SIOCSIFFLAGS, &ifr) < 0) {
+       if (ioctl(drv->global->sock, SIOCSIFFLAGS, &ifr) < 0) {
                wpa_printf(MSG_ERROR, "ioctl[SIOCSIFFLAGS]: %s",
                           strerror(errno));
                return -1;
@@ -577,7 +596,7 @@
        os_memset(&creq, 0, sizeof(creq));
        os_strlcpy(creq.i_name, drv->ifname, sizeof(creq.i_name));
        creq.i_channel = (u_int16_t)channel;
-       return ioctl(drv->sock, SIOCS80211CHANNEL, &creq);
+       return ioctl(drv->global->sock, SIOCS80211CHANNEL, &creq);
 #else /* SIOCS80211CHANNEL */
        return set80211param(priv, IEEE80211_IOC_CHANNEL, channel);
 #endif /* SIOCS80211CHANNEL */
@@ -734,7 +753,8 @@
 static void
 bsd_wireless_event_receive(int sock, void *ctx, void *sock_ctx)
 {
-       struct bsd_driver_data *drv = ctx;
+       struct bsd_driver_global *global = sock_ctx;
+       struct bsd_driver_data *drv;
        struct if_announcemsghdr *ifan;
        struct rt_msghdr *rtm;
        struct ieee80211_michael_event *mic;
@@ -743,7 +763,7 @@
        int n;
        union wpa_event_data data;
 
-       n = read(sock, drv->event_buf, drv->event_buf_len);
+       n = read(sock, global->event_buf, global->event_buf_len);
        if (n < 0) {
                if (errno != EINTR && errno != EAGAIN)
                        wpa_printf(MSG_ERROR, "%s read() failed: %s",
@@ -751,15 +771,18 @@
                return;
        }
 
-       rtm = (struct rt_msghdr *) drv->event_buf;
+       rtm = (struct rt_msghdr *) global->event_buf;
        if (rtm->rtm_version != RTM_VERSION) {
                wpa_printf(MSG_DEBUG, "Invalid routing message version=%d",
                           rtm->rtm_version);
                return;
        }
-       ifan = (struct if_announcemsghdr *) rtm;
+       drv = bsd_get_drvindex(global, rtm->rtm_index);
+       if (drv == NULL)
+               return;
        switch (rtm->rtm_type) {
        case RTM_IEEE80211:
+               ifan = (struct if_announcemsghdr *) rtm;
                switch (ifan->ifan_what) {
                case RTM_IEEE80211_ASSOC:
                case RTM_IEEE80211_REASSOC:
@@ -815,21 +838,15 @@
                return NULL;
        }
 
-       drv->event_buf_len = rtbuf_len();
-
-       drv->event_buf = os_malloc(drv->event_buf_len);
-       if (drv->event_buf == NULL) {
-               wpa_printf(MSG_ERROR, "%s: os_malloc() failed", __func__);
+       drv->ifindex = if_nametoindex(params->ifname);
+       if (drv->ifindex == 0) {
+               wpa_printf(MSG_DEBUG, "%s: interface %s does not exist",
+                          __func__, params->ifname);
                goto bad;
        }
 
        drv->hapd = hapd;
-       drv->sock = socket(PF_INET, SOCK_DGRAM, 0);
-       if (drv->sock < 0) {
-               wpa_printf(MSG_ERROR, "socket[PF_INET,SOCK_DGRAM]: %s",
-                          strerror(errno));
-               goto bad;
-       }
+       drv->global = params->global_priv;
        os_strlcpy(drv->ifname, params->ifname, sizeof(drv->ifname));
 
        drv->sock_xmit = l2_packet_init(drv->ifname, NULL, ETH_P_EAPOL,
@@ -843,29 +860,19 @@
        if (bsd_ctrl_iface(drv, 0) < 0)
                goto bad;
 
-       drv->route = socket(PF_ROUTE, SOCK_RAW, 0);
-       if (drv->route < 0) {
-               wpa_printf(MSG_ERROR, "socket(PF_ROUTE,SOCK_RAW): %s",
-                          strerror(errno));
-               goto bad;
-       }
-       eloop_register_read_sock(drv->route, bsd_wireless_event_receive, drv,
-                                NULL);
-
        if (bsd_set_mediaopt(drv, IFM_OMASK, IFM_IEEE80211_HOSTAP) < 0) {
                wpa_printf(MSG_ERROR, "%s: failed to set operation mode",
                           __func__);
                goto bad;
        }
 
+       dl_list_add(&drv->global->ifaces, &drv->list);
+
        return drv;
 bad:
        if (drv != NULL) {
                if (drv->sock_xmit != NULL)
                        l2_packet_deinit(drv->sock_xmit);
-               if (drv->sock >= 0)
-                       close(drv->sock);
-               os_free(drv->event_buf);
                os_free(drv);
        }
        return NULL;
@@ -877,16 +884,9 @@
 {
        struct bsd_driver_data *drv = priv;
 
-       if (drv->route >= 0) {
-               eloop_unregister_read_sock(drv->route);
-               close(drv->route);
-       }
        bsd_ctrl_iface(drv, 0);
-       if (drv->sock >= 0)
-               close(drv->sock);
        if (drv->sock_xmit != NULL)
                l2_packet_deinit(drv->sock_xmit);
-       os_free(drv->event_buf);
        os_free(drv);
 }
 
@@ -937,7 +937,7 @@
        struct ieee80211_bssid bs;
 
        os_strlcpy(bs.i_name, drv->ifname, sizeof(bs.i_name));
-       if (ioctl(drv->sock, SIOCG80211BSSID, &bs) < 0)
+       if (ioctl(drv->global->sock, SIOCG80211BSSID, &bs) < 0)
                return -1;
        os_memcpy(bssid, bs.i_bssid, sizeof(bs.i_bssid));
        return 0;
@@ -1191,7 +1191,8 @@
 static void
 wpa_driver_bsd_event_receive(int sock, void *ctx, void *sock_ctx)
 {
-       struct bsd_driver_data *drv = sock_ctx;
+       struct bsd_driver_global *global = sock_ctx;
+       struct bsd_driver_data *drv;
        struct if_announcemsghdr *ifan;
        struct if_msghdr *ifm;
        struct rt_msghdr *rtm;
@@ -1201,7 +1202,7 @@
        struct ieee80211_join_event *join;
        int n;
 
-       n = read(sock, drv->event_buf, drv->event_buf_len);
+       n = read(sock, global->event_buf, global->event_buf_len);
        if (n < 0) {
                if (errno != EINTR && errno != EAGAIN)
                        wpa_printf(MSG_ERROR, "%s read() failed: %s",
@@ -1209,18 +1210,20 @@
                return;
        }
 
-       rtm = (struct rt_msghdr *) drv->event_buf;
+       rtm = (struct rt_msghdr *) global->event_buf;
        if (rtm->rtm_version != RTM_VERSION) {
                wpa_printf(MSG_DEBUG, "Invalid routing message version=%d",
                           rtm->rtm_version);
                return;
        }
+       drv = bsd_get_drvindex(global, rtm->rtm_index);
+       if (drv == NULL)
+               return;
+       ctx = drv->ctx;
        os_memset(&event, 0, sizeof(event));
        switch (rtm->rtm_type) {
        case RTM_IFANNOUNCE:
                ifan = (struct if_announcemsghdr *) rtm;
-               if (ifan->ifan_index != drv->ifindex)
-                       break;
                os_strlcpy(event.interface_status.ifname, drv->ifname,
                           sizeof(event.interface_status.ifname));



Home | Main Index | Thread Index | Old Index