Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/xen/xen Fix off by one error, pointed out by Wei Li...



details:   https://anonhg.NetBSD.org/src/rev/0e124fb4c250
branches:  trunk
changeset: 338409:0e124fb4c250
user:      bouyer <bouyer%NetBSD.org@localhost>
date:      Fri May 22 10:34:13 2015 +0000

description:
Fix off by one error, pointed out by Wei Liu in port-xen/49919

diffstat:

 sys/arch/xen/xen/xenevt.c |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (45 lines):

diff -r 911e5435f863 -r 0e124fb4c250 sys/arch/xen/xen/xenevt.c
--- a/sys/arch/xen/xen/xenevt.c Fri May 22 07:44:46 2015 +0000
+++ b/sys/arch/xen/xen/xenevt.c Fri May 22 10:34:13 2015 +0000
@@ -1,4 +1,4 @@
-/*      $NetBSD: xenevt.c,v 1.41 2014/07/25 08:10:35 dholland Exp $      */
+/*      $NetBSD: xenevt.c,v 1.42 2015/05/22 10:34:13 bouyer Exp $      */
 
 /*
  * Copyright (c) 2005 Manuel Bouyer.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: xenevt.c,v 1.41 2014/07/25 08:10:35 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: xenevt.c,v 1.42 2015/05/22 10:34:13 bouyer Exp $");
 
 #include "opt_xen.h"
 #include <sys/param.h>
@@ -489,7 +489,7 @@
        if (uio->uio_resid == 0)
                return (0);
        nentries = uio->uio_resid / sizeof(uint16_t);
-       if (nentries > NR_EVENT_CHANNELS)
+       if (nentries >= NR_EVENT_CHANNELS)
                return EMSGSIZE;
        chans = kmem_alloc(nentries * sizeof(uint16_t), KM_SLEEP);
        if (chans == NULL)
@@ -582,7 +582,7 @@
        {
                struct ioctl_evtchn_unbind *unbind = addr;
                
-               if (unbind->port > NR_EVENT_CHANNELS)
+               if (unbind->port >= NR_EVENT_CHANNELS)
                        return EINVAL;
                mutex_enter(&devevent_lock);
                if (devevent[unbind->port] != d) {
@@ -603,7 +603,7 @@
        {
                struct ioctl_evtchn_notify *notify = addr;
                
-               if (notify->port > NR_EVENT_CHANNELS)
+               if (notify->port >= NR_EVENT_CHANNELS)
                        return EINVAL;
                mutex_enter(&devevent_lock);
                if (devevent[notify->port] != d) {



Home | Main Index | Thread Index | Old Index