Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/raidframe revert bp->b_error checking; biowait() is ...



details:   https://anonhg.NetBSD.org/src/rev/a3dbc315f799
branches:  trunk
changeset: 342700:a3dbc315f799
user:      christos <christos%NetBSD.org@localhost>
date:      Tue Jan 05 18:44:34 2016 +0000

description:
revert bp->b_error checking; biowait() is a no-op in that case and it is
valid to call biowait() after biodone. (thanks chuq)

diffstat:

 sys/dev/raidframe/rf_netbsdkintf.c |  12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diffs (40 lines):

diff -r 1d33fbf48742 -r a3dbc315f799 sys/dev/raidframe/rf_netbsdkintf.c
--- a/sys/dev/raidframe/rf_netbsdkintf.c        Tue Jan 05 18:16:20 2016 +0000
+++ b/sys/dev/raidframe/rf_netbsdkintf.c        Tue Jan 05 18:44:34 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: rf_netbsdkintf.c,v 1.339 2016/01/05 17:06:34 mlelstv Exp $     */
+/*     $NetBSD: rf_netbsdkintf.c,v 1.340 2016/01/05 18:44:34 christos Exp $    */
 
 /*-
  * Copyright (c) 1996, 1997, 1998, 2008-2011 The NetBSD Foundation, Inc.
@@ -101,7 +101,7 @@
  ***********************************************************/
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: rf_netbsdkintf.c,v 1.339 2016/01/05 17:06:34 mlelstv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rf_netbsdkintf.c,v 1.340 2016/01/05 18:44:34 christos Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_compat_netbsd.h"
@@ -2323,9 +2323,7 @@
        bp->b_resid = dsize;
 
        bdev_strategy(bp);
-       error = bp->b_error;
-       if (!error)
-               error = biowait(bp);
+       error = biowait(bp);
 
        if (!error) {
                memcpy(data, bp->b_data, msize);
@@ -2370,9 +2368,7 @@
        bdev_strategy(bp);
        if (asyncp)
                return 0;
-       error = bp->b_error;
-       if (!error)
-               error = biowait(bp);
+       error = biowait(bp);
        brelse(bp, 0);
        if (error) {
 #if 1



Home | Main Index | Thread Index | Old Index